Support nested html page analysis #43#52
Support nested html page analysis #43#52prix-uniris merged 4 commits intoarchethic-foundation:mainfrom
Conversation
Co-authored-by: Ankanna <mrblackode@gmail.com>
…for path assignment
|
Made the changes above mentioned. |
I guess this is too much information to display for cli, the only things we should display must be following -
Also make use of chalk https://www.npmjs.com/package/chalk |
|
I have worked on the feedback. @manujuniris Can you review it again. |
|
Review Points for this Issue:
|
blackode
left a comment
There was a problem hiding this comment.
-
Read PR description
-
Read AC
-
Pulled branch, manually tested, verified AC are met
-
Reviewed the code
-
Detection of nested files from the folder (.css, .js, .pngs, etc.)
-
Upload those files to the blockchain
-
Replace all the links in all HTML pages (index.html, about.html) which point to local links -> URLs of content on the blockchain.
-
Website properly working on blockchain. With proper links to other pages, and images/assets

-[x] Displaying missing index.html

.
|
LGTM |



It Supports Nested Html Files and Folders.
Since file folder dirs can be pretty big, using to calculate a sum of transaction costs and asking user consent for that instead of asking permission for each file.