Skip to content

Support nested html page analysis #43#52

Merged
prix-uniris merged 4 commits intoarchethic-foundation:mainfrom
prix-uniris:#43
Apr 6, 2022
Merged

Support nested html page analysis #43#52
prix-uniris merged 4 commits intoarchethic-foundation:mainfrom
prix-uniris:#43

Conversation

@prix-uniris
Copy link
Contributor

It Supports Nested Html Files and Folders.

Since file folder dirs can be pretty big, using to calculate a sum of transaction costs and asking user consent for that instead of asking permission for each file.

Copy link
Contributor

@manujuniris manujuniris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you display number of replications ?

Also, from the user perspective it is of no use to display seed and address for each file rather we can display transaction url.

prix-uniris and others added 2 commits April 2, 2022 23:02
@prix-uniris
Copy link
Contributor Author

Made the changes above mentioned.

@manujuniris
Copy link
Contributor

manujuniris commented Apr 4, 2022

Made the changes above mentioned.

Screenshot from 2022-04-04 13-15-54

I guess this is too much information to display for cli, the only things we should display must be following -

  1. Transaction fee for entire folder
  2. File paths
  3. Transaction URL's
  4. Confirmation

Also make use of chalk https://www.npmjs.com/package/chalk

@prix-uniris
Copy link
Contributor Author

prix-uniris commented Apr 4, 2022

I have worked on the feedback. @manujuniris Can you review it again.

Copy link
Contributor

@manujuniris manujuniris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following output was captured while testing this PR -

Screenshot from 2022-04-05 09-59-51

@prix-uniris
Copy link
Contributor Author

Review Points for this Issue:

  • Detection of nested files from the folder (.css, .js, .pngs, etc.)
  • Upload those files to the blockchain
  • Replace all the links in all HTML pages (index.html, about.html) which point to local links -> URLs of content on the blockchain.
  • Website properly working on blockchain. With proper links to other pages, and images/assets.

Copy link
Contributor

@blackode blackode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Read PR description

  • Read AC

  • Pulled branch, manually tested, verified AC are met

  • Reviewed the code

  • Detection of nested files from the folder (.css, .js, .pngs, etc.)

  • Aggregate Transactin fee
    image

  • Upload those files to the blockchain

  • Replace all the links in all HTML pages (index.html, about.html) which point to local links -> URLs of content on the blockchain.

  • Website properly working on blockchain. With proper links to other pages, and images/assets
    image
    -[x] Displaying missing index.html
    image

.

@blackode
Copy link
Contributor

blackode commented Apr 6, 2022

LGTM

@prix-uniris prix-uniris merged commit c55d3fa into archethic-foundation:main Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants