Support of .git folder and .gitignore #85
Support of .git folder and .gitignore #85herissondev wants to merge 10 commits intoarchethic-foundation:mainfrom
Conversation
Hi @apoorv-2204, My folder also includes a .git/HEAD file and it works fine. |
Can you please share your node js version ? |
I'm using node js v18.11.0 |
|
Added the function and it works well ! I just changed the line |
commands/cli.js
Outdated
|
|
||
| // if the folder is git folder then we should ignore | ||
| // .git and files / folders in gitignore | ||
| if (isGitFolder){ |
There was a problem hiding this comment.
We might do the reverse operation.
Instead of expecting this flag, we might look at the existence of the .gitignore file or .git folder to not deploy by default the folder attached.
But if we want to deploy the files referenced in the .gitignore, add a flag to explicit it (--include-git-ignored-files)
In all cases, there is no point to deploy the .git folder
There was a problem hiding this comment.
We might do the reverse operation.
Instead of expecting this flag, we might look at the existence of the .gitignore file or .git folder to not deploy by default the folder attached.
But if we want to deploy the files referenced in the .gitignore, add a flag to explicit it (--include-git-ignored-files)
In all cases, there is no point to deploy the .git folder
Hadn't seen your comment sorry, should be fixed now. .git is always ignored, .gitignore files are ignored by default unless --include-git-ignored-files flag is added to the deploy command.
herissondev
left a comment
There was a problem hiding this comment.
Fix conflicts
Hi @aime-risson , I was unable to push changes on your branch, I created a new pr, with merge of your branch into the new branch. With that your external contribution is still recorded!!.Will also mention as author on last commit, Cheers 😄 |
Great thanks! |
|
Related PR #93 has been merged in main branch. Closing this one |



As described in #82 aeweb-cli wasn't handeling git folders.
Therefore I added a
--git-folderargument.It works by parsing the .gitignore file and then only uploading files that do not match the gitignore patterns.
to test it simply deploy a git folder as usual but add the
--git-folderargument.