Handle website update #83#90
Handle website update #83#90Neylix merged 3 commits intoarchethic-foundation:mainfrom apoorv-2204:handle_website_update_#83
Conversation
|
I tested 3 scenarios. 2/3 are successful.
The 3rd scenario return "No files to update" |
Neylix
left a comment
There was a problem hiding this comment.
Didn't tested yet, put overall looks good, well done !
I have a suggestion, if a user delete files, they remain in the metada and so they are again added in the new reference transaction.
We may list all the files that have been passed throught the addFile function, and when we create the reference transaction we can check if there is file in metadata which are not in the file list, so we can delete them from the metadata.
Hello. |
About the directory deletion, if the previous ref tx reported some files in the deleted directory, you should then remove the files of this given directory (like git is doing) |
Yes boss we are doing this. |
I mean, empty directory suppression, has no meaning, as it has no files. And for files in directory , if they are removed, they are removed from ref tx. Maybe you can give it a try? |
This pr provides api to handle website update. When we upload a website, we might need to do some updates.
Redeploying from scratch is not an option.
Current One seed one website.
We must provide freedom to update website.
we fetch prev ref tx and compare its metadata with the updates files that user has provided.
We update metadata, for the changes files and include new files.