Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unconditional "debugger" statement is pausing execution for all tests that use LogCollectCypressFetch #221

Closed
mhseiden opened this issue Nov 1, 2023 · 1 comment
Closed

unconditional "debugger" statement is pausing execution for all tests that use LogCollectCypressFetch #221

mhseiden opened this issue Nov 1, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@mhseiden
Copy link

mhseiden commented Nov 1, 2023

A recent PR added a call to debugger into LogCollectCypressFetch. I'd imagine this was not an intended addition. However, if it was, placing it behind a config flag would be much appreciated. As is this change makes it impossible to run tests w/ the debugger open.

c8cecd9#diff-90c9af081460757175536d7f5a49daa84f3f7d79a9fe50527717e173817fa678R56
@mhseiden mhseiden changed the title unconditional "debugger" statement is pauses execution for all tests that use LogCollectCypressFetch unconditional "debugger" statement is pausing execution for all tests that use LogCollectCypressFetch Nov 1, 2023
archfz added a commit that referenced this issue Nov 1, 2023
@archfz
#221: Remove incorrectly added debugger statement.
657f954
@archfz archfz added the bug Something isn't working label Nov 1, 2023
@archfz
Copy link
Owner

archfz commented Nov 1, 2023

Indeed. Removed in 5.3.9

@archfz archfz closed this as completed Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mhseiden @archfz