Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle top level pending suites when extended collecting #90

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

jmoses
Copy link
Contributor

@jmoses jmoses commented Apr 5, 2021

If a suite is pending, do not attempt to add the after hooks
for extended log collecting

If a suite is pending, do not attempt to add the after hooks
for extended log collecting
@jmoses
Copy link
Contributor Author

jmoses commented Apr 5, 2021

Oh, also, how....is this project formatted/linted? VS code did a whole bunch of re-formatting on save that was not right. I see a prettier config, but no npm lint task, or anything. I'm not hugely experience in the js ecosystem, so I'm probably just missing something "standard"

@jmoses
Copy link
Contributor Author

jmoses commented Apr 5, 2021

If a suite is pending, the afterAll call is just a no-op.

https://github.com/mochajs/mocha/blob/ca9bfc7e13cc9411bed5cbf4ab357e4241ba269b/lib/suite.js#L282

@archfz
Copy link
Owner

archfz commented Apr 6, 2021

Nice one. Indeed there is prettier, no problem if you submit those changes as well. I might set a pipeline as well and enforce it.

@archfz archfz merged commit 28cd832 into archfz:master Apr 6, 2021
@archfz
Copy link
Owner

archfz commented Apr 6, 2021

Released in 3.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants