Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing loading a .env file for architect environment variables #753

Merged
merged 9 commits into from
Nov 30, 2022

Conversation

ryan-cahill
Copy link
Member

@ryan-cahill ryan-cahill commented Nov 8, 2022

Overview

Adds .env support for local and remote deployments and closes https://gitlab.com/architect-io/product/-/issues/189

Changes

  • Adds support for using one or more .env files with the --secret-file flag
  • Adds dotenv and dotenv-expand dependencies

Tests

  • Added a test for both local and remote deployments

Docs

Will be done with https://gitlab.com/architect-io/product/-/issues/203

@tjhiggins
Copy link
Member

Looks good - @ryan-cahill still WIP?

@ryan-cahill
Copy link
Member Author

Yeah I'd like to add some tests before this is merged

@ryan-cahill ryan-cahill changed the title [WIP] testing loading a .env file for architect environment variables testing loading a .env file for architect environment variables Nov 17, 2022
@tjhiggins tjhiggins merged commit dc0f0bc into rc Nov 30, 2022
@tjhiggins tjhiggins deleted the dotenv-support branch November 30, 2022 18:44
github-actions bot pushed a commit that referenced this pull request Nov 30, 2022
# [1.29.0-rc.10](v1.29.0-rc.9...v1.29.0-rc.10) (2022-11-30)

### Features

* **dev:** loading a .env file for architect environment variables ([#753](#753)) ([dc0f0bc](dc0f0bc))
github-actions bot pushed a commit that referenced this pull request Dec 1, 2022
# [1.29.0](v1.28.0...v1.29.0) (2022-12-01)

### Bug Fixes

* **cluster:** Updated examples to remove type flag. ([4e58979](4e58979))
* **dev:** Fix race condition inspecting containers that no longer exist, fixed bug with service_ref / full_service_name being incorrect, only log healthcheck once each time it happens ([#763](#763)) ([734356a](734356a))
* **register:** Default register path to ./architect.yml ([#765](#765)) ([01fa335](01fa335))
* **register:** Fix warning when dependencies are already registered ([#766](#766)) ([a593ea9](a593ea9))
* **validation:** validator for looser validation on account names ([#761](#761)) ([93d6859](93d6859))

### Features

* **dev:** loading a .env file for architect environment variables ([#753](#753)) ([dc0f0bc](dc0f0bc))
* **dev:** Log errors when liveness probe fails ([#759](#759)) ([0c65d19](0c65d19))
* **environment:create:** Warn when environment creation fails due to already existing environment ([#556](#556)) ([bb17f80](bb17f80))
* **init:** Support creating projects from Architect templates ([#612](#612)) ([45283a0](45283a0)), closes [#695](#695)
* **secrets:** Allow secrets from a remote env to be used in local development ([012e459](012e459))
@github-actions
Copy link

github-actions bot commented Dec 1, 2022

🎉 This PR is included in version 1.29.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants