fixing warning when dependencies are already registered #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtgoncalves1
approved these changes
Nov 30, 2022
TylerAldrich
approved these changes
Nov 30, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Nov 30, 2022
# [1.29.0-rc.8](v1.29.0-rc.7...v1.29.0-rc.8) (2022-11-30) ### Bug Fixes * **register:** Fix warning when dependencies are already registered ([#766](#766)) ([a593ea9](a593ea9))
github-actions bot
pushed a commit
that referenced
this pull request
Dec 1, 2022
# [1.29.0](v1.28.0...v1.29.0) (2022-12-01) ### Bug Fixes * **cluster:** Updated examples to remove type flag. ([4e58979](4e58979)) * **dev:** Fix race condition inspecting containers that no longer exist, fixed bug with service_ref / full_service_name being incorrect, only log healthcheck once each time it happens ([#763](#763)) ([734356a](734356a)) * **register:** Default register path to ./architect.yml ([#765](#765)) ([01fa335](01fa335)) * **register:** Fix warning when dependencies are already registered ([#766](#766)) ([a593ea9](a593ea9)) * **validation:** validator for looser validation on account names ([#761](#761)) ([93d6859](93d6859)) ### Features * **dev:** loading a .env file for architect environment variables ([#753](#753)) ([dc0f0bc](dc0f0bc)) * **dev:** Log errors when liveness probe fails ([#759](#759)) ([0c65d19](0c65d19)) * **environment:create:** Warn when environment creation fails due to already existing environment ([#556](#556)) ([bb17f80](bb17f80)) * **init:** Support creating projects from Architect templates ([#612](#612)) ([45283a0](45283a0)), closes [#695](#695) * **secrets:** Allow secrets from a remote env to be used in local development ([012e459](012e459))
|
🎉 This PR is included in version 1.29.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes https://gitlab.com/architect-io/architect-cli/-/issues/574 by making sure that there are actually dependencies to warn about before warning
Changes
\nchar in places where the warning should start after an empty lineTests