Catch error when trying to hit accounts endpoint, fallback to allowing user to select a local env #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wing user to select a local env
github-actions bot
pushed a commit
that referenced
this pull request
Apr 24, 2023
# [1.39.0-rc.5](v1.39.0-rc.4...v1.39.0-rc.5) (2023-04-24) ### Bug Fixes * **exec:** Catch error when trying to hit accounts endpoint and fallback to allowing user to select a local env ([#897](#897)) ([8cd0732](8cd0732))
github-actions bot
pushed a commit
that referenced
this pull request
Apr 26, 2023
# [1.39.0](v1.38.0...v1.39.0) (2023-04-26) ### Bug Fixes * **dev:** Require dev port selected is 80, 443, or between 1024-65535 ([#895](#895)) ([c35a27b](c35a27b)) * **error:** Provide better error messages when you have conflicting subdomains ([3d8b2e1](3d8b2e1)) * **exec:** Catch error when trying to hit accounts endpoint and fallback to allowing user to select a local env ([#897](#897)) ([8cd0732](8cd0732)) * **revert:** Revert deprecation warnings for liveness_probe keys ([cc7653d](cc7653d)) * **spec:** Add safe float type to avoid precision loss on yaml.load ([#894](#894)) ([e14e0cd](e14e0cd)) ### Features * **dev:** Automatic cache cleanup ([#857](#857)) ([8b46457](8b46457)) * **init:** Handle Docker Compose environment variable interpolation formats ([#881](#881)) ([6c30882](6c30882)) * **spec:** deprecate liveness_probe port and path keys ([#896](#896)) ([9e2104c](9e2104c))
|
🎉 This PR is included in version 1.39.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can happen if a user has an invalid token (for some reason) or an expired token. We'll attempt to hit the accounts endpoint, it will return an error, and the exec command would silently fail and not give the user any explanation.
If this happens now, it'll warn the user that they need to login, but still allow them to select the local dev environment and exec locally as normal.
Ticket: https://gitlab.com/architect-io/architect-cli/-/issues/660