Convert compose interpolations

[mtgoncalves1]

Overview

Closes https://gitlab.com/architect-io/architect-cli/-/issues/467.
Make sure docker compose interpolation gets converted to our syntax correctly.

Changes

• Convert any compose environment variables with the format of ${*} to Architect format ${{ * }} and create a secret for each of them

Tests

docker-compose.yml

version: '3.2'
services:
  db:
    image: "postgres:${POSTGRES_VERSION}"
    environment:
      POSTGRES_USER: ${DB_USER}
      POSTGRES_PASSWORD: ${DB_PASSWORD}
      POSTGRES_DB: ${DB_NAME}

Run the init command. It should result in the following architect file.
$ architect-local init --from-compose=docker-compose.yml test

name: test
services:
  db:
    image: postgres:${{ secrets.POSTGRES_VERSION }}
    environment:
      POSTGRES_USER: ${{ secrets.DB_USER }}
      POSTGRES_PASSWORD: ${{ secrets.DB_PASSWORD }}
      POSTGRES_DB: ${{ secrets.DB_NAME }}
    reserved_name: db
secrets:
  POSTGRES_VERSION:
    required: true
  DB_USER:
    required: true
  DB_PASSWORD:
    required: true
  DB_NAME:
    required: true

[mueschm]

The server_online.sh script is not working. More than likely, the number of services changed due to the test update. Should be easy and a good learning experience to update the script and fix everything.

[tjhiggins]

The server_online.sh script is not working. More than likely, the number of services changed due to the test update. Should be easy and a good learning experience to update the script and fix everything.

I had the same issue. Which is how I went down the --wait path. This pr should fix the issue:
#880

[ryan-cahill]

It looks like we should take three more cases into account here, $VARIABLE, ${VARIABLE:-default}, and ${VARIABLE:?err}. The last two are convenient in that they use either default or required environment variables and match up well with our spec. Also because of the fact that a syntax to require environment variables exists in a docker-compose file, I think that secrets specified as just ${VARIABLE} or $VARIABLE shouldn't be required secrets. From the docs:

Both $VARIABLE and ${VARIABLE} syntax are supported. Additionally when using the 2.1 file format, it is possible to provide inline default values using typical shell syntax:

${VARIABLE:-default} evaluates to default if VARIABLE is unset or empty in the environment.
${VARIABLE-default} evaluates to default only if VARIABLE is unset in the environment.
Similarly, the following syntax allows you to specify mandatory variables:

${VARIABLE:?err} exits with an error message containing err if VARIABLE is unset or empty in the environment.
${VARIABLE?err} exits with an error message containing err if VARIABLE is unset in the environment.

Also please add tests to test/commands/init.test.ts for these cases

[mtgoncalves1]

I think that secrets specified as just ${VARIABLE} or $VARIABLE shouldn't be required secrets.
Ok. I'll leave them as

secrets:
  VARIABLE:
    default:

[ryan-cahill]

I think that secrets specified as just ${VARIABLE} or $VARIABLE shouldn't be required secrets.
Ok. I'll leave them as

secrets:
  VARIABLE:
    default:

I think that rather than an empty default property, required: false might be more appropriate

[mtgoncalves1]

I think that secrets specified as just ${VARIABLE} or $VARIABLE shouldn't be required secrets.
Ok. I'll leave them as

secrets:
  VARIABLE:
    default:

I think that rather than an empty default property, required: false might be more appropriate

Sounds good.

[github-actions]

🎉 This PR is included in version 1.39.0 🎉

The release is available on:

• v1.39.0
• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀