Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing healthcheck liveness probe protocol for port/path #678

Merged
merged 2 commits into from
Aug 19, 2022
Merged

fixing healthcheck liveness probe protocol for port/path #678

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90a48d4
fixing healthcheck liveness probe protocol for port/path
ryan-cahill Aug 19, 2022
059cb96
adding test for path/port healthchecks
ryan-cahill Aug 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/common/docker-compose/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ export class DockerComposeUtils {
volumes: {},
};

const protocol = use_ssl ? 'https' : 'http';
const limit = pLimit(5);
const port_promises = [];

Expand Down Expand Up @@ -180,7 +179,7 @@ export class DockerComposeUtils {
const liveness_probe = node.config.liveness_probe;
if (liveness_probe) {
if (!liveness_probe.command) {
liveness_probe.command = ['CMD-SHELL', `curl -f ${protocol}://localhost:${liveness_probe.port}${liveness_probe.path} || exit 1`]; // deprecated
liveness_probe.command = ['CMD-SHELL', `curl -f http://localhost:${liveness_probe.port}${liveness_probe.path} || exit 1`]; // deprecated
} else {
liveness_probe.command = ['CMD', ...liveness_probe.command];
}
Expand Down