567-add-additional-data-as-tags #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjhiggins
requested changes
Nov 23, 2022
tjhiggins
requested changes
Nov 30, 2022
tjhiggins
previously requested changes
Dec 2, 2022
TylerAldrich
reviewed
Dec 6, 2022
TylerAldrich
approved these changes
Dec 7, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Dec 7, 2022
## [1.29.1-rc.4](v1.29.1-rc.3...v1.29.1-rc.4) (2022-12-07) ### Bug Fixes * **sentry:** Log flags/commands as tags for searching ([#762](#762)) ([d821dea](d821dea))
github-actions bot
pushed a commit
that referenced
this pull request
Dec 14, 2022
# [1.30.0](v1.29.0...v1.30.0) (2022-12-14) ### Bug Fixes * **graph:** Fix dependency edges for new interfaces spec ([#776](#776)) ([1913d8e](1913d8e)) * **register:** Fixing register for services with reserved names ([#777](#777)) ([6f465af](6f465af)) * **reserved_name:** Remove architect_ref to avoid confusion ([#778](#778)) ([4967e7d](4967e7d)) * **sentry:** Log flags/commands as tags for searching ([#762](#762)) ([d821dea](d821dea)) * **webkit:** Add check for regex lookbehind support ([#770](#770)) ([8698a2d](8698a2d)) * **webkit:** regex ([#771](#771)) ([b74cccd](b74cccd)) * **webkit:** Use RegExp so catch triggers ([cccfded](cccfded)) ### Features * **spec:** Deprecate top level interfaces block ([#775](#775)) ([9144120](9144120))
|
🎉 This PR is included in version 1.30.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see https://gitlab.com/architect-io/architect-cli/-/issues/567
Overview
Sentry transactions for the CLI project assigns command flags under Additional Data. Additional Data is not indexed for search, so there is no way to filter search results for a particular flag value used. Eg., wanting to see architect dev/deploy commands that have used the -i flag.
Changes
Update sentry startTransaction to add command flags passed by argument to CLI as tags to sentry.
Move logic for setting additional data into start sentry transaction.
Tests
npm run testarchitect environmentsarchitect environments -a architectDocs
N/A