Dependencies without tags

src/commands/register.ts

@@ -9,7 +9,7 @@ import yaml from 'js-yaml';
 import path from 'path';
 import tmp from 'tmp';
 import untildify from 'untildify';
-import { ArchitectError, buildNodeRef, buildSpecFromPath, ComponentSlugUtils, ComponentSpec, DependencyGraphMutable, Dictionary, dumpToYml, resourceRefToNodeRef, ServiceNode, ServiceSpec, Slugs, TaskNode, validateInterpolation, VolumeSpec } from '../';
+import { ArchitectError, buildNodeRef, buildSpecFromPath, ComponentSlugUtils, ComponentSpec, DependencyGraphMutable, DependencySpec, Dictionary, dumpToYml, resourceRefToNodeRef, ServiceNode, ServiceSpec, Slugs, TaskNode, validateInterpolation, VolumeSpec } from '../';
 import Account from '../architect/account/account.entity';
 import AccountUtils from '../architect/account/account.utils';
 import { EnvironmentUtils, GetEnvironmentOptions } from '../architect/environment/environment.utils';
@@ -441,10 +441,16 @@ export default class ComponentRegister extends BaseCommand {
     return flags.environment ? `${ENV_TAG_PREFIX}${flags.environment}` : flags.tag;
   }
 
-  private async generateDependenciesWarnings(component_dependencies: Dictionary<string>, account_name: string) {
+  private async generateDependenciesWarnings(component_dependencies: Dictionary<string | DependencySpec>, account_name: string) {
     const dependency_arr: string[] = [];
-    for (const [component_name, tag] of Object.entries(component_dependencies)) {
-      dependency_arr.push(`${component_name}:${tag}`);
+    for (const [component_name, tag_or_object] of Object.entries(component_dependencies)) {
+      if (typeof tag_or_object === 'string') {
+        dependency_arr.push(`${component_name}:${tag_or_object}`);
+      } else if (tag_or_object.tag) {
+        dependency_arr.push(`${component_name}:${tag_or_object.tag}`);
+      } else {
+        dependency_arr.push(`${component_name}:latest`);
+      }
     }
     const dependencies: Dictionary<{ component: boolean, component_and_version: boolean }> = (await this.app.api.get(`accounts/${account_name}/components-tags`, { params: { components: dependency_arr } })).data;
 

src/common/dependency-manager/local-manager.ts

@@ -122,8 +122,8 @@ export default class LocalDependencyManager extends DependencyManager {
       const component_spec = await this.loadComponentSpec(component_ref, undefined, debug);
       component_specs.push(component_spec);
 
-      for (const [dep_name, dep_tag] of Object.entries(component_spec.dependencies || {})) {
-        component_refs_queue.push(`${dep_name}:${dep_tag}`);
+      for (const dep_name of Object.keys(component_spec.dependencies || {})) {
+        component_refs_queue.push(`${dep_name}`);
       }
     }
     return component_specs;

src/dependency-manager/config/component-config.ts

@@ -1,4 +1,4 @@
-import { ComponentInstanceMetadata, ComponentSpec } from '../spec/component-spec';
+import { ComponentInstanceMetadata, ComponentSpec, DependencySpec } from '../spec/component-spec';
 import { SecretSpecValue } from '../spec/secret-spec';
 import { ComponentSlugUtils, ParsedResourceSlug, ResourceSlugUtils, ResourceType, Slugs } from '../spec/utils/slugs';
 import { Dictionary } from '../utils/dictionary';
@@ -35,7 +35,7 @@ export interface ComponentConfig {
   services: Dictionary<ServiceConfig>;
   databases: Dictionary<DatabaseConfig>;
   tasks: Dictionary<TaskConfig>;
-  dependencies: Dictionary<string>;
+  dependencies: Dictionary<string | DependencySpec>;
 
   artifact_image?: string;
 }

src/dependency-manager/spec/component-spec.ts

@@ -31,6 +31,19 @@ export interface ComponentInstanceMetadata {
   interpolated?: boolean;
 }
 
+@JSONSchema({
+  description: 'An empty object that optionally supports specifying a tag for backwards compatibility.',
+})
+export class DependencySpec {
+  @IsOptional()
+  @JSONSchema({
+    type: 'string',
+    pattern: Slugs.ComponentTagValidator.source,
+    deprecated: true,
+  })
+  tag?: string;
+}
+
 @JSONSchema({
   description: 'Component Interfaces are the primary means by which components advertise their resolvable addresses to others. Interfaces are the only means by which other components can communicate with your component.',
 })
@@ -234,19 +247,20 @@ export class ComponentSpec {
     type: 'object',
 
     patternProperties: {
-      [ComponentSlugUtils.Validator.source]: {
+      [ComponentSlugUtils.Validator.source]: AnyOf({
         type: 'string',
         pattern: Slugs.ComponentTagValidator.source,
-      },
+      }, DependencySpec),
     },
 
     errorMessage: {
       additionalProperties: ComponentSlugUtils.Description,
     },
 
-    description: 'A key-value set of dependencies and their respective tags. Reference each dependency by component name (e.g. `cloud: latest`)',
+    description: 'A key-value set of dependencies with an empty value. Reference each dependency by component name (e.g. `cloud: {}`)',
   })
-  dependencies?: Dictionary<string>;
+  @Transform(transformObject(DependencySpec))
+  dependencies?: Dictionary<string | DependencySpec>;
 
   @IsOptional()
   @JSONSchema({

src/dependency-manager/spec/utils/json-schema-annotations.ts

@@ -23,6 +23,8 @@ export const AnyOf = (...args: any): DecoratorSchema => {
       anyOf.push({
         $ref: `${REF_PREFIX}${arg.name}`,
       });
+    } else if (typeof arg === 'object' && 'type' in arg && 'pattern' in arg) {
+      anyOf.push(arg);
     } else {
       console.error(arg);
       throw new Error('Illegal arg for JsonSchema in AnyOf. You must specify either a primitive string or a Type.');

src/dependency-manager/spec/utils/json-schema.ts

@@ -78,11 +78,10 @@ export const findDefinition = (pointer: string, schema: SchemaObject): SchemaObj
  * @param obj
  */
 const recursivelyReplaceDebugRefs = (obj: SchemaObject) => {
+  if (!obj || typeof obj !== 'object') {
+    return;
+  }
   for (const k of Object.keys(obj)) {
-    if (!obj || typeof obj !== 'object') {
-      return;
-    }
-
     if (k === '$ref') {
       obj[k] = `${REF_PREFIX}${DEBUG_PREFIX}${obj[k].replace(REF_PREFIX, '')}`;
     }

test/dependency-manager/components.test.ts

@@ -284,7 +284,7 @@ describe('components spec v1', function () {
           },
         },
         dependencies: {
-          'ci': '6.2',
+          'ci': {},
         },
         interfaces: {},
       };
@@ -347,7 +347,7 @@ describe('components spec v1', function () {
       const worker_node = graph.getNodeByRef(worker_ref) as ServiceNode;
       expect(worker_node.config.environment.CONCOURSE_TSA_HOST).eq(web_ref);
       expect(worker_node.config.name).to.eq('worker');
-      expect(worker_node.config.metadata.tag).to.eq('6.2');
+      expect(worker_node.config.metadata.tag).to.eq('latest');
       expect(worker_node.config.metadata.ref).to.eq('ci.services.worker');
     });
 

test/dependency-manager/dependencies.test.ts

@@ -1,11 +1,10 @@
 import { expect } from '@oclif/test';
 import axios from 'axios';
 import mock_fs from 'mock-fs';
-import { resourceRefToNodeRef, ServiceNode } from '../../src';
+import { buildSpecFromYml, resourceRefToNodeRef, ServiceNode, ValidationErrors } from '../../src';
 import LocalDependencyManager from '../../src/common/dependency-manager/local-manager';
 
 describe('dependencies', () => {
-
   it('circular dependencies', async () => {
     const cloud_config = `
       name: cloud
@@ -63,12 +62,96 @@ describe('dependencies', () => {
     expect(app.config.environment).to.deep.equal({
       SERVER_ADDR: `http://${server_ref}:8080`,
       SERVER_EXT_ADDR: `http://server.arc.localhost`
-    })
+    });
 
     const server = graph.getNodeByRef(server_ref) as ServiceNode;
     expect(server.config.environment).to.deep.equal({
       CLOUD_ADDR: `http://${app_ref}:8080`,
       CLOUD_EXT_ADDR: `http://app.arc.localhost`
-    })
+    });
+  });
+
+  describe('dependency validation', () => {
+    it('dependencies with no tag are valid', async () => {
+      const component_config = `
+        name: component
+        dependencies:
+          server: {}
+      `;
+      buildSpecFromYml(component_config);
+    });
+
+    it('dependencies with string tag are still valid', async () => {
+      const component_config = `
+        name: component
+        dependencies:
+          server: im-a-tag
+      `;
+      buildSpecFromYml(component_config);
+    });
+
+    it('dependencies with invalid string tag are still invalid', async () => {
+      const component_config = `
+        name: component
+        dependencies:
+          server: im-an-invalid-tag!
+      `;
+
+      expect(() => {
+        buildSpecFromYml(component_config);
+      }).to.throw(ValidationErrors);
+    });
+
+    it('dependencies with tag as dictionary key is valid', async () => {
+      const component_config = `
+        name: component
+        dependencies:
+          server:
+            tag: im-a-tag
+      `;
+
+      buildSpecFromYml(component_config);
+    });
+
+    it('dependencies with invalid tag as dictionary key is invalid', async () => {
+      const component_config = `
+        name: component
+        dependencies:
+          server:
+            tag: im-an-invalid-tag!
+      `;
+
+      expect(() => {
+        buildSpecFromYml(component_config);
+      }).to.throw(ValidationErrors);
+    });
+
+    it('dependencies with invalid keys are invalid', async () => {
+      const component_config = `
+        name: component
+        dependencies:
+          server:
+            foo: bar
+            baz: bingo
+      `;
+
+      expect(() => {
+        buildSpecFromYml(component_config);
+      }).to.throw(ValidationErrors);
+    });
+
+    it('dependencies with valid and invalid keys are invalid', async () => {
+      const component_config = `
+        name: component
+        dependencies:
+          server:
+            foo: bar
+            tag: im-a-tag
+      `;
+
+      expect(() => {
+        buildSpecFromYml(component_config);
+      }).to.throw(ValidationErrors);
+    });
   });
 });

test/dependency-manager/reserved-names.test.ts

@@ -316,17 +316,17 @@ describe('components with reserved_name field set', function () {
         services: {
           api: {
             interfaces: {
-              main: 8080
+              main: 8080,
             },
             environment: {
               CONCOURSE_ADDR: '${{ dependencies.ci.interfaces.web.url }}'
             }
           }
         },
         dependencies: {
-          'ci': '6.2'
+          'ci': {},
         },
-        interfaces: {}
+        interfaces: {},
       };
 
       const concourse_component_config = {
@@ -388,7 +388,7 @@ describe('components with reserved_name field set', function () {
       expect(worker_node.config.environment.CONCOURSE_TSA_HOST).eq(web_ref);
       expect(worker_node.config.name).to.eq('worker');
       expect(worker_node.ref).to.eq(reserved_name);
-      expect(worker_node.config.metadata.tag).to.eq('6.2');
+      expect(worker_node.config.metadata.tag).to.eq('latest');
       expect(worker_node.config.metadata.ref).to.eq('ci.services.worker');
     });