Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable network policy test #912

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Conversation

TylerAldrich
Copy link
Contributor

@TylerAldrich TylerAldrich commented May 16, 2023

Re-enabling the network policy test now that we can create an env from the command line with zero-trust enabled: https://gitlab.com/architect-io/architect-cli/-/issues/583

The port number and error message we were looking for both seem to have been changed since this test last worked - I tested this against an environment with zero-trust enabled and disabled to make sure the test worked correctly:

(Environment with zero-trust enabled is ztrust, the default disabled zero trust is example-environment)

~/code/architect/architect-cli (reenable-network-policy-test*) » architect-dev exec -a test-tyler -e ztrust superset.services.stateful-api -- sh -c  "curl --connect-timeout 10 --insecure -L -I http://hello-world--api:8080/ || true" > network_policy_test.txt 2>&1 </dev/null
if [[ $(cat network_policy_test.txt) == *"Timeout was reached"* ]]; then echo "good"; else echo "bad"; fi
good
--------------------------------------------------------------------------------------------------------------------------------------
~/code/architect/architect-cli (reenable-network-policy-test*) » architect-dev exec -a test-tyler -e example-environment superset.services.stateful-api -- sh -c  "curl --connect-timeout 10 --insecure -L -I http://hello-world--api:8080/ || true" > network_policy_test.txt 2>&1 </dev/null
if [[ $(cat network_policy_test.txt) == *"Timeout was reached"* ]]; then echo "good"; else echo "bad"; fi
bad

Working superset test when I modified the action to run on this branch: https://github.com/architect-team/architect-cli/actions/runs/4993800453/jobs/8943435801

@TylerAldrich TylerAldrich changed the title [DO NOT MERGE] Re-enable network policy test Re-enable network policy test May 16, 2023
@TylerAldrich TylerAldrich marked this pull request as ready for review May 16, 2023 17:49
@TylerAldrich TylerAldrich merged commit 113b0c7 into rc Oct 19, 2023
@TylerAldrich TylerAldrich deleted the reenable-network-policy-test branch October 19, 2023 15:20
github-actions bot pushed a commit that referenced this pull request Oct 19, 2023
# [1.44.0-rc.3](v1.44.0-rc.2...v1.44.0-rc.3) (2023-10-19)

### Bug Fixes

* **tests:** Re-enable network policy test ([#912](#912)) ([113b0c7](113b0c7))
github-actions bot pushed a commit that referenced this pull request Oct 19, 2023
# [1.44.0](v1.43.0...v1.44.0) (2023-10-19)

### Bug Fixes

* **deps:** pinning sentry to a stable version ([#924](#924)) ([5becc15](5becc15))
* **tests:** Re-enable network policy test ([#912](#912)) ([113b0c7](113b0c7))

### Features

* **spec:** allowing an ip whitelist to be submitted as a comma-delimited string of ips/cidrs ([#923](#923)) ([7436f28](7436f28))
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant