Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic logging that can be enabled with --verbose #10

Closed
wants to merge 2 commits into from

Conversation

pifantastic
Copy link

...ption.

@pifantastic pifantastic changed the title Add basic logging that can be disabled with the --verbose command line o... Add basic logging that can be enabled with --verbose Jul 31, 2014
@pifantastic
Copy link
Author

Hey! Any chance of getting this merged?

@mhart
Copy link
Collaborator

mhart commented Sep 30, 2014

Hey there - sorry I've been sitting on it for so long.

I'm actually not a huge fan of winston - we used it for a while at my last job and it didn't hold up too well. Although things have probably changed since then. We ended up using bunyan which we much preferred.

In this case, I'm not even sure if adding another large dependency (and all its sub-dependencies) is even necessary. console.log and console.error might suffice for this just fine.

@pifantastic
Copy link
Author

@mhart no worries, thanks for taking a look. Honestly I chose winston because i was being lazy and I wanted the logs to be "pretty". I can understand you not wanting to add a dependency for something simple. I'll find some time to swap it out.

@ryanblock
Copy link
Member

@pifantastic I know it's only like 8 years later, but if you'd like to update this to use console.error, I'd be happy to merge!

@ryanblock ryanblock mentioned this pull request Aug 30, 2023
4 tasks
@ryanblock
Copy link
Member

Merging this got a bit out of hand for such a small change, so I'll replicate the spirit of it (sans winston) and give some props in the changelog to you, @pifantastic – thank you!

@ryanblock ryanblock closed this Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants