Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new error text to recognize ESM-only imports #77

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lpsinger
Copy link

@lpsinger lpsinger commented Dec 8, 2024

This error message was added in Node.js 22.0.0:
npm/node@5f7fad2

Thank you for helping out! ✨

We really appreciate your commitment to improving Architect

To maintain a high standard of quality in our releases, before merging every pull request we ask that you've completed the following:

  • Forked the repo and created your branch from main
  • Made sure tests pass (run npm it from the repo root)
  • Expanded test coverage related to your changes:
    • Added and/or updated unit tests (if appropriate)
    • Added and/or updated integration tests (if appropriate)
  • Updated relevant documentation:
  • Summarized your changes in changelog.md
  • Linked to any related issues, PRs, etc. below that may relate to, consume, or necessitate these changes

Please also be sure to completed the CLA (if you haven't already).

Learn more about contributing to Architect here.

Thanks again!

This error message was added in Node.js 22.0.0:
npm/node@5f7fad2
@lpsinger
Copy link
Author

lpsinger commented Dec 8, 2024

See nasa-gcn/gcn.nasa.gov#2760.

lpsinger added a commit to lpsinger/gcn.nasa.gov that referenced this pull request Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant