Skip to content

Conversation

chuongmep
Copy link
Contributor

@chuongmep chuongmep commented Jun 27, 2022

Dear @daren-thomas, @eirannejad !

This is a big pull request include :

  • Support latest version Revit 2023 ( From 2018-2023).

  • Update target project Style .NET6( core still is .NET 4.8) long time maintain support .

  • Support CI/CD Automatic build version from Revit 2018- Revit 2023.Result in my branch : https://github.com/chuongmep/revitpythonshell/runs/7069937324?check_suite_focus=true
    image
    I think may be good if we can create a branch dev to support for colaborator can create pull to this.
    image

  • Process build msi will be automatic publish if we write changelog version and modify version in installer, final it will push to section relsease.
    image

  • Improve Readme :
    image

  • Fix problem owner show dialiog and show main window console.

  • Improve way call class from command to create a button.

  • Test addin : Tested in revit 2019,2020,2021,2022,2023, it working perfect in my computer.

image

  • Add Templete report issuse and pull request for colab.
  • Add .gitignore
  • Remove process build iss inside file confict of event project.

@jeremytammik
Copy link

wow, what fantastic enhancements! afaik, daren has discontinued this project, and ehsan was considering integrating it into pyRevit instead. with these enhancements, you may well be breathing new life into it! i would love it to continue!

@chuongmep chuongmep changed the title Automatic Process CI/CI Maintain Support 2023 Automatic Process CI/CD Maintain Support 2023 Jun 27, 2022
@daren-thomas daren-thomas requested review from eirannejad and daren-thomas and removed request for eirannejad June 27, 2022 15:27
@daren-thomas
Copy link
Member

@chuongmep thank you for your effort! I'll take a look! From a reviewer's perspective, having multiple smaller PRs is a lot easier (for next time). I'm very happy to see this project still alive and kicking! (I won't be able to test any of this, as I don't have access to Revit anymore)

@chuongmep
Copy link
Contributor Author

@daren-thomas yes, so i have also reviewed and tested this many times before making a pull request, that's what's most essential for them to last longer.

Copy link
Member

@daren-thomas daren-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant work! Some of my comments ended up being unnecessary: I was reviewing by commit and later commits addressed them, so ignore as needed.

  • Please make sure we have the copyright for the background image of the installer (?)
  • Please add yourself to the credits list!
  • Consider adding a section to the README about why the version numbers changed.

@chuongmep
Copy link
Contributor Author

@daren-thomas

  • No copyright about image
  • Many thanks, I added to readme and resolve small problem character no need when commit
  • Okay, I will add to change log for this, it will be note automatic when we have a publish version.

@daren-thomas daren-thomas merged commit c51e5ad into architecture-building-systems:master Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants