-
Notifications
You must be signed in to change notification settings - Fork 120
Automatic Process CI/CD Maintain Support 2023 #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic Process CI/CD Maintain Support 2023 #122
Conversation
wow, what fantastic enhancements! afaik, daren has discontinued this project, and ehsan was considering integrating it into pyRevit instead. with these enhancements, you may well be breathing new life into it! i would love it to continue! |
@chuongmep thank you for your effort! I'll take a look! From a reviewer's perspective, having multiple smaller PRs is a lot easier (for next time). I'm very happy to see this project still alive and kicking! (I won't be able to test any of this, as I don't have access to Revit anymore) |
@daren-thomas yes, so i have also reviewed and tested this many times before making a pull request, that's what's most essential for them to last longer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant work! Some of my comments ended up being unnecessary: I was reviewing by commit and later commits addressed them, so ignore as needed.
- Please make sure we have the copyright for the background image of the installer (?)
- Please add yourself to the credits list!
- Consider adding a section to the README about why the version numbers changed.
|
Dear @daren-thomas, @eirannejad !
This is a big pull request include :
Support latest version Revit 2023 ( From 2018-2023).
Update target project Style .NET6( core still is .NET 4.8) long time maintain support .
Support CI/CD Automatic build version from Revit 2018- Revit 2023.Result in my branch : https://github.com/chuongmep/revitpythonshell/runs/7069937324?check_suite_focus=true


I think may be good if we can create a branch
dev
to support for colaborator can create pull to this.Process build msi will be automatic publish if we write changelog version and modify version in installer, final it will push to section relsease.

Improve Readme :

Fix problem owner show dialiog and show main window console.
Improve way call class from command to create a button.
Test addin : Tested in revit 2019,2020,2021,2022,2023, it working perfect in my computer.