This repository was archived by the owner on Feb 19, 2020. It is now read-only.
Add multi-file coverage parsing #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @spresse1, Codacy should allow you to send one coverage report by commit and by language. Meaning that you should be able to send us a coverage report for JS and another for python, and Codacy would take care of merging the coverage information. If you think that is not happening, ping us on the support chat (as soon as you login you will see on the bottom right a help button), so that we can check what's happening please. |
|
Hi @spresse1 Were you able to check my previous suggestion regarding the upload of one coverage report by language? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging cobertura XML is hard - there isn't a utility to do it. Unfortunately, while working in a repo of mine, I had to use two different test harnesses (one for python, one for JS - see https://github.com/spresse1/remote_thermostat). Both can output to xml, but have no other common formats. The codacy API appears to only retain the last coverage report uploaded.
Based on this situation, I decided it would be best to give the python uploader the ability to merge multiple XML input files.
This implementation merges the python structure that is turned into JSON before uploading. This means that if, in the future, the uploader adds additional supported input formats, this code can be used to perform merges over multiple formats.
This PR is fully backwards compatible (at least according to the tests). I've also added tests for the new functionality.
Comments and requests for revision are absolutely welcome.