Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

l10n/po: update Tamil translation #2392

Merged
merged 2 commits into from
Apr 15, 2024
Merged

l10n/po: update Tamil translation #2392

merged 2 commits into from
Apr 15, 2024

Conversation

kbdharun
Copy link
Contributor

@kbdharun kbdharun commented Mar 8, 2024

PR Description:

This PR updates the Tamil translation with updated translations (for modified/added strings) and minor fixes to existing strings.

Tests and Checks

  • I have tested the code!

@kbdharun kbdharun requested a review from Torxed as a code owner March 8, 2024 03:07
Copy link
Contributor Author

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was confused why the Time syncronization not completing string was repeating here but not shown in my side of Interface.

Seems like it is present twice in the POT file too.

image

msgid ""
"Time syncronization not completing, while you wait - check the docs for "
"workarounds: https://archinstall.readthedocs.io/"
msgstr ""
msgid ""
"Skipping waiting for automatic time sync (this can cause issues if time is "
"out of sync during installation)"
msgstr ""
msgid ""
"Waiting for Arch Linux keyring sync (archlinux-keyring-wkd-sync) to complete."
msgstr ""
msgid "Selected profiles: "
msgstr ""
msgid ""
"Time synchronization not completing, while you wait - check the docs for "
"workarounds: https://archinstall.readthedocs.io/"
msgstr ""

@Torxed
Copy link
Member

Torxed commented Mar 8, 2024

Not sure why that would be. Maybe it's poedit making a fuzz because it's been split into multiple lines in base.po upstream:

msgid ""
"Time syncronization not completing, while you wait - check the docs for "
"workarounds: https://archinstall.readthedocs.io/"

You can do a git pull origin master (or use the web ui https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork) into your master to see if the behavior disappear.

@kbdharun
Copy link
Contributor Author

kbdharun commented Mar 8, 2024

You can do a git pull origin master (or use the web ui https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork) into your master to see if the behavior disappear.

Hi, my branch is already synced with the master branch, the string repeats twice in the upstream POT file (base.pot). Should I remove the second one? (I linked this code line as a permalink in the previous comment for your reference earlier today)

@Torxed
Copy link
Member

Torxed commented Mar 8, 2024

the string repeats twice in the upstream POT file

I linked to the upstream .po file, and I could not find a duplicate.
Mind linking to the duplicate string?

@kbdharun
Copy link
Contributor Author

kbdharun commented Mar 8, 2024

the string repeats twice in the upstream POT file

I linked to the upstream .po file, and I could not find a duplicate. Mind linking to the duplicate string?

Sure, the string is present in lines 1246-1249 (A) and also repeated in 1263-1266 lines (B) in the template "base.pot" file under archinstall/archinstall/locales directory.

A:

msgid ""
"Time syncronization not completing, while you wait - check the docs for "
"workarounds: https://archinstall.readthedocs.io/"
msgstr ""

B:

msgid ""
"Time synchronization not completing, while you wait - check the docs for "
"workarounds: https://archinstall.readthedocs.io/"
msgstr ""

@Torxed
Copy link
Member

Torxed commented Mar 10, 2024

Aah, because one is misspelled 🙈
We should for sure just use correct spelling ^^

Time syncronization
Time synchronization

@Torxed Torxed merged commit 2c87f0e into archlinux:master Apr 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants