Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using VCS as pyparted version lock #2494

Merged
merged 1 commit into from
May 9, 2024
Merged

Conversation

Torxed
Copy link
Member

@Torxed Torxed commented May 9, 2024

Changing to use github archive as dependency-url for pyparted as there hasn't been an update on pypi.org for pyparted in almost 12 months.

Tracking issue: dcantrell/pyparted#106

Instead of downgrading, I think it's a safe bet that we should stop hoping for upstream to listen. Or at least I need to get this out of my ever growing backlog - as it occupies mental realestate like crazy.

So.. In PEP 508 spirit - despite it being against red hats own bloody guidelines where @dcantrell seemingly work - let's use the github archive as a version lock.. at least for pip users. Because downgrading really isn't an option. We'll keep using VCS or pypi wherever possible, but for pip this is the only decent workaround.

renovate-bot appears to honor PEP508 - but I haven't tested it if truth be told.

This superseeds:

…e hasn't been an update on pypi.org for pyparted in almost 12 months. Tracking issue dcantrell/pyparted#106
@Torxed Torxed assigned svartkanin and unassigned svartkanin May 9, 2024
@Torxed Torxed requested a review from svartkanin May 9, 2024 21:46
@svartkanin
Copy link
Collaborator

Nice I didn't even know that's possible

@Torxed Torxed changed the title pyparted dependency version lock change Using VCS as pyparted version lock May 9, 2024
@Torxed Torxed merged commit 3381cd5 into master May 9, 2024
11 checks passed
@Torxed Torxed deleted the change-pyparted-version branch May 9, 2024 21:50
@Torxed
Copy link
Member Author

Torxed commented May 9, 2024

Yeah it's not commonly used, as you're supposed to be able to grab packages from pypi.org or package them via package managers. But it gets the job done here I recon hehe.

You can do pip install git+https://github.com/dcantrell/pyparted.git --break-system-packages too, to get the latest version. But since we're locking and using renovate-bot I thought this would be a nice similar experience :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants