Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip devices that fail to get pyparted Disk #2526

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Skip devices that fail to get pyparted Disk #2526

merged 1 commit into from
Jun 4, 2024

Conversation

codefiles
Copy link
Contributor

@codefiles codefiles commented Jun 4, 2024 •
edited
Loading

Fixes #2524

  • Skip devices that raise a DiskException and log the exception message
  • Use newDisk() instead of Disk() like pyparted examples
  • Use newDisk() if lsblk info contains a partition table type else use freshDisk()

@codefiles codefiles requested a review from Torxed as a code owner June 4, 2024 14:40
@svartkanin svartkanin merged commit 6747c9e into archlinux:master Jun 4, 2024
6 checks passed
@codefiles codefiles deleted the log-disk-error branch June 5, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svartkanin svartkanin svartkanin approved these changes

@Torxed Torxed Awaiting requested review from Torxed Torxed is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error with archinstall on MacBook9,1
2 participants
@codefiles @svartkanin