Enable pytest test runs on CI #2947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also fixes fixture and test issues that caused failures.
svartkanin
reviewed
Nov 27, 2024
| assert arch_config == ArchConfig( | ||
| version='3.0.0', | ||
| version=archinstall.__version__, |
There was a problem hiding this comment.
This will break the tests every time there's a new version released
There was a problem hiding this comment.
Hmm, the fixture specifies 2.8.6, so it seems like the latest version is being substituted elsewhere. Here's the failure I saw when I kept 3.0.0 in place:
E Drill down into differing attribute version:
E version: '3.0.1' != '3.0.0'
E - 3.0.0
E ? ^
E + 3.0.1
E ? ^
There was a problem hiding this comment.
Right, I'll need to have a deeper look into it. Lets get it in for now as the PR is a good improvement, thanks for that
svartkanin
approved these changes
Nov 27, 2024
castillofrancodamian
pushed a commit
to castillofrancodamian/archinstall
that referenced
this pull request
Dec 21, 2024
This commit also fixes fixture and test issues that caused failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description:
This commit also fixes fixture and test issues that caused failures.