Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the explicit-f-string-type-conversion rule and fix warnings #2954

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Enable the explicit-f-string-type-conversion rule and fix warnings #2954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion archinstall/lib/disk/subvolume_menu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def _add_subvolume(self, preset: SubvolumeModification | None = None) -> Subvolu
case ResultType.Reset:
raise ValueError('Unhandled result type')

header = f"{str(_('Subvolume name'))}: {name}\n"
header = f"{_('Subvolume name')}: {name}\n"

path = prompt_dir(
str(_("Subvolume mountpoint")),
Expand Down
4 changes: 2 additions & 2 deletions archinstall/lib/global_menu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ def _prev_network_config(self, item: MenuItem) -> str | None:
if network_config.type == NicType.MANUAL:
output = FormattedOutput.as_table(network_config.nics)
else:
output = f'{str(_('Network configuration'))}:\n{network_config.type.display_msg()}'
output = f'{_('Network configuration')}:\n{network_config.type.display_msg()}'

return output
return None
Expand Down Expand Up @@ -363,7 +363,7 @@ def _prev_swap(self, item: MenuItem) -> str | None:

def _prev_uki(self, item: MenuItem) -> str | None:
if item.value is not None:
output = f'{str(_('Unified kernel images'))}: '
output = f'{_('Unified kernel images')}: '
output += str(_('Enabled')) if item.value else str(_('Disabled'))
return output
return None
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,6 @@ ignore = [
"E722", # bare-except
"PLW2901", # redefined-loop-name
"RUF005", # collection-literal-concatenation
"RUF010", # explicit-f-string-type-conversion
"RUF012", # mutable-class-default
"RUF015", # unnecessary-iterable-allocation-for-first-element
"RUF039", # unraw-re-pattern
Expand Down