Remove disk retries and timeouts #3025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svartkanin
approved these changes
Dec 19, 2024
castillofrancodamian
pushed a commit
to castillofrancodamian/archinstall
that referenced
this pull request
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The retires in
encrypt()should not be necessary and it is the only placeDISK_RETRY_ATTEMPTSandDISK_TIMEOUTSever get used anymore. The rationale for removal is that encrypting takes place after partitioning just as formatting does. If the partitions are able to be formatted directly after partitioning then they should also be able to be encrypted directly after partitioning, it is the same. Prior to 00b0ae7, formatting had similar logic which has since been removed without issue.