Ruff django rule #512
Merged
Ruff django rule #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We request all pgp_key's in a loop which would lead to 100 queries, prefetching the userprofile makes the page load with 26 queries as of writing.
The rebuilderd status is only shown for logged in users so fetching this is unneeded.
An inclusion_tag renders a template on every request, for the glibc page this meant calling Template.render() 7529 times(!) and loading ~ 5 seconds on my AMD Ryzen 7 5700X 8 Core. With this change we now do 3629 Template.render calls in 500 ms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.