Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checkservices: add auditd.service to ignore list and resolve shellcheck warnings #82

Merged
merged 7 commits into from
Aug 22, 2024
Merged

checkservices: add auditd.service to ignore list and resolve shellcheck warnings #82

merged 7 commits into from
Aug 22, 2024

Commits on Aug 22, 2024

  1. checkservices: add auditd.service to the list of ignored services 

    An attempt to restart auditd.service results in the following error:

Failed to restart auditd.service: Operation refused, unit auditd.service may be requested by dependency only (it is configured to refuse manual start/stop).
See system logs and 'systemctl status auditd.service' for details.
    @lahwaacz
    lahwaacz committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    591c72e View commit details
    Browse the repository at this point in the history

  2. checkservices: replace tabs and fix typo in a comment

    @lahwaacz
    lahwaacz committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    c5733f8 View commit details
    Browse the repository at this point in the history

  3. checkservices: remove unused variable

    @lahwaacz
    lahwaacz committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    d3f4bac View commit details
    Browse the repository at this point in the history

  4. checkservices: rewrite for loop to avoid shellcheck warning about unu… 

    …sed variable
    @lahwaacz
    lahwaacz committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    f19a19c View commit details
    Browse the repository at this point in the history

  5. checkservices: fix quoting 

    Shellcheck issues SC2046, SC2053, SC2086, SC2184
    @lahwaacz
    lahwaacz committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    9f5c0c3 View commit details
    Browse the repository at this point in the history

  6. checkservices: remove unnecessary $ on arithmetic variables 

    This resolves shellcheck warning SC2004.
    @lahwaacz
    lahwaacz committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    1b02602 View commit details
    Browse the repository at this point in the history

  7. checkservices: use mapfile to split command output 

    This resolves the shellcheck warning SC2207.

I think we want to split by newlines rather than arbitrary whitespace in
all cases...
    @lahwaacz
    lahwaacz committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    24bcbf4 View commit details
    Browse the repository at this point in the history