Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP 8.4 deprecation warning #18

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Fix PHP 8.4 deprecation warning #18

merged 1 commit into from
Dec 16, 2024

Conversation

Ercasor
Copy link
Contributor

@Ercasor Ercasor commented Dec 6, 2024

WARN PHP Deprecated: Stancl\JobPipeline\JobPipeline::__construct(): Implicitly marking parameter $send as nullable is deprecated, the explicit nullable type must be used instead in vendor/stancl/jobpipeline/src/JobPipeline.php on line 31.

 WARN  PHP Deprecated: Stancl\JobPipeline\JobPipeline::__construct(): Implicitly marking parameter $send as nullable is deprecated, the explicit nullable type must be used instead in vendor/stancl/jobpipeline/src/JobPipeline.php on line 31.
@stancl
Copy link
Member

stancl commented Dec 6, 2024

Can you send a PR for the 1.x branch as well?

@Ercasor
Copy link
Contributor Author

Ercasor commented Dec 6, 2024

Can you send a PR for the 1.x branch as well?

done

@stancl stancl merged commit d17ee43 into archtechx:2.x Dec 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants