Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/escrow add contract #14

Merged
merged 7 commits into from
Aug 1, 2022
Merged

Feature/escrow add contract #14

merged 7 commits into from
Aug 1, 2022

Conversation

gachouchani1999
Copy link
Contributor

Add escrow template that works with cargo generate
Closes #12

aelesbao
aelesbao previously approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@aelesbao aelesbao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I only noticed one minor issue.

Besides that, the build is failing. I know it's unrelated to this PR, but could you please fix the error before merging?

cw20/escrow/src/contract.rs Outdated Show resolved Hide resolved
@gachouchani1999 @aelesbao
Update cw20/escrow/src/contract.rs
0faf824 
Co-authored-by: Augusto Elesbão <aelesbao@users.noreply.github.com>
santanaluiz
santanaluiz previously approved these changes Jun 29, 2022
View reviewed changes
@santanaluiz
Copy link

looks good.
I approved, but we should naturally make sure it is building before merging

@gachouchani1999
Copy link
Contributor Author

@santanaluiz yes building is facing the issue with cargo generate Generating project from local repository (branch ) ... Error: Please check if the Git user / repository exists. Caused by: the given reference name 'refs/remotes/origin/' is not valid; class=Reference (4); code=InvalidSpec (-[12](https://github.com/archway-network/archway-templates/runs/7094237155?check_suite_focus=true#step:5:13)) Error: Process completed with exit code 1.

@gachouchani1999 gachouchani1999 mentioned this pull request Jul 4, 2022
Open
@gachouchani1999
Copy link
Contributor Author

Same issue as #15 in build fail before closing

@gachouchani1999 gachouchani1999 merged commit e0a41a0 into main Aug 1, 2022
@gachouchani1999 gachouchani1999 deleted the feature/escrow-add-contract branch August 1, 2022 10:58
@aelesbao aelesbao mentioned this pull request Aug 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aelesbao aelesbao aelesbao approved these changes

@santanaluiz santanaluiz Awaiting requested review from santanaluiz

@drewstaylor drewstaylor Awaiting requested review from drewstaylor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import the escrow contract as a template
3 participants
@gachouchani1999 @santanaluiz @aelesbao