-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add detect sensitive info rule #1300
Conversation
😎 Merged successfully - details. |
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
3260b56
to
d67ecf8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some quick feedback. Chatted with @e-moran about some of it and he said he'll move stuff around and cleanup.
9917645
to
fb07e77
Compare
The problem seemed to be that GitHub Actions creates a merge commit when run on PRs, so it found that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I commented inline as I was changing things and addressed some stuff. I wanted to get things I could change easily done so @e-moran can touch the bigger stuff and we hopefully can get this wrapped up tomorrow. I re-flagged the big things that weren't addressed or weren't answered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits and various cleanup but we're nearly done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work here! Excited to get this released next week 💪
Automatically generated with [Release Please](https://github.com/googleapis/release-please). --- <details><summary>@arcjet/analyze: 1.0.0-alpha.22</summary> ## [1.0.0-alpha.22](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.21...@arcjet/analyze-v1.0.0-alpha.22) (2024-08-26) ### 🚀 New Features * add detect sensitive info rule ([#1300](#1300)) ([006e344](006e344)) ### Dependencies * The following workspace dependencies were updated * dependencies * @arcjet/protocol bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * devDependencies * @arcjet/eslint-config bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/rollup-config bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/tsconfig bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 </details> <details><summary>@arcjet/body: 1.0.0-alpha.22</summary> ## [1.0.0-alpha.22](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.21...@arcjet/body-v1.0.0-alpha.22) (2024-08-26) ### 🚀 New Features * add detect sensitive info rule ([#1300](#1300)) ([006e344](006e344)) ### Dependencies * The following workspace dependencies were updated * devDependencies * @arcjet/eslint-config bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/rollup-config bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/tsconfig bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 </details> <details><summary>@arcjet/bun: 1.0.0-alpha.22</summary> ## [1.0.0-alpha.22](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.21...@arcjet/bun-v1.0.0-alpha.22) (2024-08-26) ### 🚀 New Features * add detect sensitive info rule ([#1300](#1300)) ([006e344](006e344)) ### Dependencies * The following workspace dependencies were updated * dependencies * @arcjet/env bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/headers bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/ip bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/logger bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/protocol bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/transport bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * arcjet bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * devDependencies * @arcjet/eslint-config bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/rollup-config bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/tsconfig bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 </details> <details><summary>@arcjet/decorate: 1.0.0-alpha.22</summary> ## [1.0.0-alpha.22](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.21...@arcjet/decorate-v1.0.0-alpha.22) (2024-08-26) ### ⚠ BREAKING CHANGES * **tsconfig:** Enable verbatim module syntax ([#1324](#1324)) ### 🧹 Miscellaneous Chores * **tsconfig:** Enable verbatim module syntax ([#1324](#1324)) ([7012b54](7012b54)), closes [#1314](#1314) ### Dependencies * The following workspace dependencies were updated * dependencies * @arcjet/protocol bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/sprintf bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * devDependencies * @arcjet/eslint-config bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/rollup-config bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/tsconfig bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 </details> <details><summary>@arcjet/duration: 1.0.0-alpha.22</summary> ## [1.0.0-alpha.22](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.21...@arcjet/duration-v1.0.0-alpha.22) (2024-08-26) ### 🧹 Miscellaneous Chores * **@arcjet/duration:** Synchronize arcjet-js versions ### Dependencies * The following workspace dependencies were updated * devDependencies * @arcjet/eslint-config bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/rollup-config bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/tsconfig bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 </details> <details><summary>@arcjet/env: 1.0.0-alpha.22</summary> ## [1.0.0-alpha.22](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.21...@arcjet/env-v1.0.0-alpha.22) (2024-08-26) ### 🧹 Miscellaneous Chores * **@arcjet/env:** Synchronize arcjet-js versions ### Dependencies * The following workspace dependencies were updated * devDependencies * @arcjet/eslint-config bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/rollup-config bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/tsconfig bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 </details> <details><summary>@arcjet/eslint-config: 1.0.0-alpha.22</summary> ## [1.0.0-alpha.22](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.21...@arcjet/eslint-config-v1.0.0-alpha.22) (2024-08-26) ### 🧹 Miscellaneous Chores * **@arcjet/eslint-config:** Synchronize arcjet-js versions </details> <details><summary>@arcjet/headers: 1.0.0-alpha.22</summary> ## [1.0.0-alpha.22](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.21...@arcjet/headers-v1.0.0-alpha.22) (2024-08-26) ### 🧹 Miscellaneous Chores * **@arcjet/headers:** Synchronize arcjet-js versions ### Dependencies * The following workspace dependencies were updated * devDependencies * @arcjet/eslint-config bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/rollup-config bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/tsconfig bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 </details> <details><summary>@arcjet/ip: 1.0.0-alpha.22</summary> ## [1.0.0-alpha.22](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.21...@arcjet/ip-v1.0.0-alpha.22) (2024-08-26) ### ⚠ BREAKING CHANGES * **tsconfig:** Enable verbatim module syntax ([#1324](#1324)) ### 🧹 Miscellaneous Chores * **tsconfig:** Enable verbatim module syntax ([#1324](#1324)) ([7012b54](7012b54)), closes [#1314](#1314) ### Dependencies * The following workspace dependencies were updated * devDependencies * @arcjet/eslint-config bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/rollup-config bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/tsconfig bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 </details> <details><summary>@arcjet/logger: 1.0.0-alpha.22</summary> ## [1.0.0-alpha.22](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.21...@arcjet/logger-v1.0.0-alpha.22) (2024-08-26) ### 🧹 Miscellaneous Chores * **@arcjet/logger:** Synchronize arcjet-js versions ### Dependencies * The following workspace dependencies were updated * dependencies * @arcjet/sprintf bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * devDependencies * @arcjet/eslint-config bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/rollup-config bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/tsconfig bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 </details> <details><summary>@arcjet/next: 1.0.0-alpha.22</summary> ## [1.0.0-alpha.22](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.21...@arcjet/next-v1.0.0-alpha.22) (2024-08-26) ### ⚠ BREAKING CHANGES * **tsconfig:** Enable verbatim module syntax ([#1324](#1324)) ### 🚀 New Features * add detect sensitive info rule ([#1300](#1300)) ([006e344](006e344)) ### 🧹 Miscellaneous Chores * **tsconfig:** Enable verbatim module syntax ([#1324](#1324)) ([7012b54](7012b54)), closes [#1314](#1314) ### Dependencies * The following workspace dependencies were updated * dependencies * @arcjet/env bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/headers bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/ip bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/logger bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/protocol bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/transport bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * arcjet bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * devDependencies * @arcjet/eslint-config bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/rollup-config bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/tsconfig bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 </details> <details><summary>@arcjet/node: 1.0.0-alpha.22</summary> ## [1.0.0-alpha.22](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.21...@arcjet/node-v1.0.0-alpha.22) (2024-08-26) ### 🚀 New Features * add detect sensitive info rule ([#1300](#1300)) ([006e344](006e344)) ### Dependencies * The following workspace dependencies were updated * dependencies * @arcjet/env bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/headers bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/ip bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/logger bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/protocol bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/transport bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/body bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * arcjet bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * devDependencies * @arcjet/eslint-config bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/rollup-config bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/tsconfig bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 </details> <details><summary>@arcjet/protocol: 1.0.0-alpha.22</summary> ## [1.0.0-alpha.22](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.21...@arcjet/protocol-v1.0.0-alpha.22) (2024-08-26) ### ⚠ BREAKING CHANGES * **tsconfig:** Enable verbatim module syntax ([#1324](#1324)) ### 🚀 New Features * add detect sensitive info rule ([#1300](#1300)) ([006e344](006e344)) ### 🧹 Miscellaneous Chores * **tsconfig:** Enable verbatim module syntax ([#1324](#1324)) ([7012b54](7012b54)), closes [#1314](#1314) ### Dependencies * The following workspace dependencies were updated * devDependencies * @arcjet/eslint-config bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/rollup-config bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/tsconfig bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 </details> <details><summary>@arcjet/rollup-config: 1.0.0-alpha.22</summary> ## [1.0.0-alpha.22](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.21...@arcjet/rollup-config-v1.0.0-alpha.22) (2024-08-26) ### 🧹 Miscellaneous Chores * **@arcjet/rollup-config:** Synchronize arcjet-js versions ### Dependencies * The following workspace dependencies were updated * devDependencies * @arcjet/eslint-config bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/tsconfig bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 </details> <details><summary>@arcjet/runtime: 1.0.0-alpha.22</summary> ## [1.0.0-alpha.22](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.21...@arcjet/runtime-v1.0.0-alpha.22) (2024-08-26) ### 🧹 Miscellaneous Chores * **@arcjet/runtime:** Synchronize arcjet-js versions ### Dependencies * The following workspace dependencies were updated * devDependencies * @arcjet/eslint-config bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/rollup-config bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/tsconfig bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 </details> <details><summary>@arcjet/sprintf: 1.0.0-alpha.22</summary> ## [1.0.0-alpha.22](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.21...@arcjet/sprintf-v1.0.0-alpha.22) (2024-08-26) ### 🧹 Miscellaneous Chores * **@arcjet/sprintf:** Synchronize arcjet-js versions ### Dependencies * The following workspace dependencies were updated * devDependencies * @arcjet/eslint-config bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/rollup-config bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/tsconfig bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 </details> <details><summary>@arcjet/sveltekit: 1.0.0-alpha.22</summary> ## [1.0.0-alpha.22](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.21...@arcjet/sveltekit-v1.0.0-alpha.22) (2024-08-26) ### 🚀 New Features * add detect sensitive info rule ([#1300](#1300)) ([006e344](006e344)) ### Dependencies * The following workspace dependencies were updated * dependencies * @arcjet/env bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/headers bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/ip bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/logger bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/protocol bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/transport bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * arcjet bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * devDependencies * @arcjet/eslint-config bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/rollup-config bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/tsconfig bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 </details> <details><summary>@arcjet/transport: 1.0.0-alpha.22</summary> ## [1.0.0-alpha.22](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.21...@arcjet/transport-v1.0.0-alpha.22) (2024-08-26) ### 🧹 Miscellaneous Chores * **@arcjet/transport:** Synchronize arcjet-js versions ### Dependencies * The following workspace dependencies were updated * devDependencies * @arcjet/eslint-config bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/rollup-config bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/tsconfig bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 </details> <details><summary>@arcjet/tsconfig: 1.0.0-alpha.22</summary> ## [1.0.0-alpha.22](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.21...@arcjet/tsconfig-v1.0.0-alpha.22) (2024-08-26) ### ⚠ BREAKING CHANGES * **tsconfig:** Enable verbatim module syntax ([#1324](#1324)) ### 🧹 Miscellaneous Chores * **tsconfig:** Enable verbatim module syntax ([#1324](#1324)) ([7012b54](7012b54)), closes [#1314](#1314) </details> <details><summary>arcjet: 1.0.0-alpha.22</summary> ## [1.0.0-alpha.22](v1.0.0-alpha.21...arcjet-v1.0.0-alpha.22) (2024-08-26) ### ⚠ BREAKING CHANGES * **tsconfig:** Enable verbatim module syntax ([#1324](#1324)) ### 🚀 New Features * add detect sensitive info rule ([#1300](#1300)) ([006e344](006e344)) ### 🧹 Miscellaneous Chores * **tsconfig:** Enable verbatim module syntax ([#1324](#1324)) ([7012b54](7012b54)), closes [#1314](#1314) ### Dependencies * The following workspace dependencies were updated * dependencies * @arcjet/analyze bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/duration bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/headers bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/protocol bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/runtime bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * devDependencies * @arcjet/eslint-config bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/rollup-config bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 * @arcjet/tsconfig bumped from 1.0.0-alpha.21 to 1.0.0-alpha.22 </details> <details><summary>1.0.0-alpha.22</summary> ## [1.0.0-alpha.22](v1.0.0-alpha.21...v1.0.0-alpha.22) (2024-08-26) ### ⚠ BREAKING CHANGES * **tsconfig:** Enable verbatim module syntax ([#1324](#1324)) ### 🚀 New Features * add detect sensitive info rule ([#1300](#1300)) ([006e344](006e344)) ### 🧹 Miscellaneous Chores * **tsconfig:** Enable verbatim module syntax ([#1324](#1324)) ([7012b54](7012b54)), closes [#1314](#1314) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Adds a new rule that can be used to detect sensitive information being sent in a request when it isn't expected.