Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Switch Next.js to peer dependency #339

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Conversation

blaine-arcjet
Copy link
Contributor

Closes #336

Next.js uses symbols on their objects, which breaks TypeScript compilation if you have version mismatches. This moves it to a peer dependency so the application version is always used. The peer dep version range is anything from 13, 14, and up because I don't really like putting an upper cap on it (what if Next.js 15 releases and it doesn't break our usage... it shouldn't cause churn for our users).

@blaine-arcjet blaine-arcjet requested a review from a team as a code owner March 8, 2024 22:20
Copy link

trunk-io bot commented Mar 8, 2024

😎 Merged successfully - details.

Copy link

socket-security bot commented Mar 8, 2024

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@blaine-arcjet
Copy link
Contributor Author

@SocketSecurity ignore-all

@trunk-io trunk-io bot merged commit cb82883 into main Mar 11, 2024
14 checks passed
@trunk-io trunk-io bot deleted the phated/nextjs-peer-dep branch March 11, 2024 15:57
trunk-io bot pushed a commit that referenced this pull request Mar 11, 2024
This makes next a peerDep in our eslint package (similar to #339). I've made the version `>=14` because we only use this with next 14.

This is might be removed completely when we decide on #337
trunk-io bot pushed a commit that referenced this pull request Mar 13, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>@arcjet/decorate: 1.0.0-alpha.10</summary>

## [1.0.0-alpha.10](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.9...@arcjet/decorate-v1.0.0-alpha.10) (2024-03-13)


### 📦 Dependencies

* **dev:** Bump @rollup/wasm-node from 4.12.0 to 4.12.1 ([#320](#320)) ([7f07a8f](7f07a8f))
* **dev:** Bump @rollup/wasm-node from 4.12.1 to 4.13.0 ([#359](#359)) ([8658316](8658316))
* **dev:** Bump typescript from 5.3.3 to 5.4.2 ([#321](#321)) ([e0c2914](e0c2914))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @arcjet/logger bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
    * @arcjet/protocol bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
  * devDependencies
    * @arcjet/eslint-config bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
    * @arcjet/rollup-config bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
    * @arcjet/tsconfig bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
</details>

<details><summary>@arcjet/duration: 1.0.0-alpha.10</summary>

## [1.0.0-alpha.10](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.9...@arcjet/duration-v1.0.0-alpha.10) (2024-03-13)


### 📦 Dependencies

* **dev:** Bump @rollup/wasm-node from 4.12.0 to 4.12.1 ([#320](#320)) ([7f07a8f](7f07a8f))
* **dev:** Bump @rollup/wasm-node from 4.12.1 to 4.13.0 ([#359](#359)) ([8658316](8658316))
* **dev:** Bump typescript from 5.3.3 to 5.4.2 ([#321](#321)) ([e0c2914](e0c2914))


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @arcjet/eslint-config bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
    * @arcjet/rollup-config bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
    * @arcjet/tsconfig bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
</details>

<details><summary>@arcjet/next: 1.0.0-alpha.10</summary>

## [1.0.0-alpha.10](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.9...@arcjet/next-v1.0.0-alpha.10) (2024-03-13)


### ⚠ BREAKING CHANGES

* Switch Next.js to peer dependency ([#339](#339))

### 📦 Dependencies

* **dev:** Bump @rollup/wasm-node from 4.12.0 to 4.12.1 ([#320](#320)) ([7f07a8f](7f07a8f))
* **dev:** Bump @rollup/wasm-node from 4.12.1 to 4.13.0 ([#359](#359)) ([8658316](8658316))
* **dev:** Bump typescript from 5.3.3 to 5.4.2 ([#321](#321)) ([e0c2914](e0c2914))


### 🧹 Miscellaneous Chores

* Switch Next.js to peer dependency ([#339](#339)) ([cb82883](cb82883))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @arcjet/ip bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
    * arcjet bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
  * devDependencies
    * @arcjet/eslint-config bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
    * @arcjet/rollup-config bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
    * @arcjet/tsconfig bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
</details>

<details><summary>@arcjet/node: 1.0.0-alpha.10</summary>

## [1.0.0-alpha.10](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.9...@arcjet/node-v1.0.0-alpha.10) (2024-03-13)


### 📦 Dependencies

* **dev:** Bump @rollup/wasm-node from 4.12.0 to 4.12.1 ([#320](#320)) ([7f07a8f](7f07a8f))
* **dev:** Bump @rollup/wasm-node from 4.12.1 to 4.13.0 ([#359](#359)) ([8658316](8658316))
* **dev:** Bump typescript from 5.3.3 to 5.4.2 ([#321](#321)) ([e0c2914](e0c2914))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @arcjet/ip bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
    * arcjet bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
  * devDependencies
    * @arcjet/eslint-config bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
    * @arcjet/rollup-config bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
    * @arcjet/tsconfig bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
</details>

<details><summary>@arcjet/analyze: 1.0.0-alpha.10</summary>

## [1.0.0-alpha.10](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.9...@arcjet/analyze-v1.0.0-alpha.10) (2024-03-13)


### 🚀 New Features

* **analyze:** Replace wasm-bindgen with jco generated bindings ([#334](#334)) ([48359ff](48359ff))


### 📦 Dependencies

* **dev:** Bump @bytecodealliance/jco from 1.0.2 to 1.0.3 ([#365](#365)) ([bb1470e](bb1470e))
* **dev:** Bump @rollup/wasm-node from 4.12.0 to 4.12.1 ([#320](#320)) ([7f07a8f](7f07a8f))
* **dev:** Bump @rollup/wasm-node from 4.12.1 to 4.13.0 ([#359](#359)) ([8658316](8658316))
* **dev:** Bump typescript from 5.3.3 to 5.4.2 ([#321](#321)) ([e0c2914](e0c2914))


### 🧹 Miscellaneous Chores

* **analyze:** Replace node import with crypto global ([#335](#335)) ([bcc27f2](bcc27f2))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @arcjet/logger bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
  * devDependencies
    * @arcjet/eslint-config bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
    * @arcjet/rollup-config bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
    * @arcjet/tsconfig bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
</details>

<details><summary>@arcjet/eslint-config: 1.0.0-alpha.10</summary>

## [1.0.0-alpha.10](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.9...@arcjet/eslint-config-v1.0.0-alpha.10) (2024-03-13)


### 📦 Dependencies

* Bump eslint-config-next from 14.1.1 to 14.1.3 ([#322](#322)) ([9b99345](9b99345))
* Bump eslint-config-turbo from 1.12.4 to 1.12.5 ([#340](#340)) ([3d28dd9](3d28dd9))


### 🧹 Miscellaneous Chores

* Make next a peerDep in our eslint package ([#344](#344)) ([89de5a8](89de5a8))
</details>

<details><summary>@arcjet/ip: 1.0.0-alpha.10</summary>

## [1.0.0-alpha.10](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.9...@arcjet/ip-v1.0.0-alpha.10) (2024-03-13)


### 📦 Dependencies

* **dev:** Bump @rollup/wasm-node from 4.12.0 to 4.12.1 ([#320](#320)) ([7f07a8f](7f07a8f))
* **dev:** Bump @rollup/wasm-node from 4.12.1 to 4.13.0 ([#359](#359)) ([8658316](8658316))
* **dev:** Bump typescript from 5.3.3 to 5.4.2 ([#321](#321)) ([e0c2914](e0c2914))


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @arcjet/eslint-config bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
    * @arcjet/rollup-config bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
    * @arcjet/tsconfig bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
</details>

<details><summary>@arcjet/logger: 1.0.0-alpha.10</summary>

## [1.0.0-alpha.10](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.9...@arcjet/logger-v1.0.0-alpha.10) (2024-03-13)


### 📦 Dependencies

* **dev:** Bump @rollup/wasm-node from 4.12.0 to 4.12.1 ([#320](#320)) ([7f07a8f](7f07a8f))
* **dev:** Bump @rollup/wasm-node from 4.12.1 to 4.13.0 ([#359](#359)) ([8658316](8658316))
* **dev:** Bump typescript from 5.3.3 to 5.4.2 ([#321](#321)) ([e0c2914](e0c2914))


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @arcjet/eslint-config bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
    * @arcjet/rollup-config bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
    * @arcjet/tsconfig bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
</details>

<details><summary>@arcjet/protocol: 1.0.0-alpha.10</summary>

## [1.0.0-alpha.10](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.9...@arcjet/protocol-v1.0.0-alpha.10) (2024-03-13)


### 📦 Dependencies

* **dev:** Bump @rollup/wasm-node from 4.12.0 to 4.12.1 ([#320](#320)) ([7f07a8f](7f07a8f))
* **dev:** Bump @rollup/wasm-node from 4.12.1 to 4.13.0 ([#359](#359)) ([8658316](8658316))
* **dev:** Bump typescript from 5.3.3 to 5.4.2 ([#321](#321)) ([e0c2914](e0c2914))


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @arcjet/eslint-config bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
    * @arcjet/rollup-config bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
    * @arcjet/tsconfig bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
</details>

<details><summary>@arcjet/rollup-config: 1.0.0-alpha.10</summary>

## [1.0.0-alpha.10](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.9...@arcjet/rollup-config-v1.0.0-alpha.10) (2024-03-13)


### ⚠ BREAKING CHANGES

* Switch Next.js to peer dependency ([#339](#339))

### 📦 Dependencies

* **dev:** Bump @rollup/wasm-node from 4.12.0 to 4.12.1 ([#320](#320)) ([7f07a8f](7f07a8f))
* **dev:** Bump @rollup/wasm-node from 4.12.1 to 4.13.0 ([#359](#359)) ([8658316](8658316))
* **dev:** Bump typescript from 5.3.3 to 5.4.2 ([#321](#321)) ([e0c2914](e0c2914))


### 🧹 Miscellaneous Chores

* Switch Next.js to peer dependency ([#339](#339)) ([cb82883](cb82883))


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @arcjet/eslint-config bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
    * @arcjet/tsconfig bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
</details>

<details><summary>@arcjet/tsconfig: 1.0.0-alpha.10</summary>

## [1.0.0-alpha.10](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.9...@arcjet/tsconfig-v1.0.0-alpha.10) (2024-03-13)


### 🧹 Miscellaneous Chores

* **@arcjet/tsconfig:** Synchronize arcjet-js versions
</details>

<details><summary>arcjet: 1.0.0-alpha.10</summary>

## [1.0.0-alpha.10](v1.0.0-alpha.9...arcjet-v1.0.0-alpha.10) (2024-03-13)


### 🚀 New Features

* **analyze:** Replace wasm-bindgen with jco generated bindings ([#334](#334)) ([48359ff](48359ff))


### 📦 Dependencies

* **dev:** Bump @rollup/wasm-node from 4.12.0 to 4.12.1 ([#320](#320)) ([7f07a8f](7f07a8f))
* **dev:** Bump @rollup/wasm-node from 4.12.1 to 4.13.0 ([#359](#359)) ([8658316](8658316))
* **dev:** Bump typescript from 5.3.3 to 5.4.2 ([#321](#321)) ([e0c2914](e0c2914))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @arcjet/analyze bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
    * @arcjet/duration bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
    * @arcjet/logger bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
    * @arcjet/protocol bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
  * devDependencies
    * @arcjet/eslint-config bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
    * @arcjet/rollup-config bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
    * @arcjet/tsconfig bumped from 1.0.0-alpha.9 to 1.0.0-alpha.10
</details>

<details><summary>1.0.0-alpha.10</summary>

## [1.0.0-alpha.10](v1.0.0-alpha.9...v1.0.0-alpha.10) (2024-03-13)


### ⚠ BREAKING CHANGES

* Switch Next.js to peer dependency ([#339](#339))

### 🚀 New Features

* **analyze:** Replace wasm-bindgen with jco generated bindings ([#334](#334)) ([48359ff](48359ff))


### 📦 Dependencies

* Bump eslint-config-next from 14.1.1 to 14.1.3 ([#322](#322)) ([9b99345](9b99345))
* Bump eslint-config-turbo from 1.12.4 to 1.12.5 ([#340](#340)) ([3d28dd9](3d28dd9))
* Bump next from 14.1.1 to 14.1.3 ([#323](#323)) ([0bad5fe](0bad5fe))
* **dev:** Bump @bytecodealliance/jco from 1.0.2 to 1.0.3 ([#365](#365)) ([bb1470e](bb1470e))
* **dev:** Bump @rollup/wasm-node from 4.12.0 to 4.12.1 ([#320](#320)) ([7f07a8f](7f07a8f))
* **dev:** Bump @rollup/wasm-node from 4.12.1 to 4.13.0 ([#359](#359)) ([8658316](8658316))
* **dev:** Bump typescript from 5.3.3 to 5.4.2 ([#321](#321)) ([e0c2914](e0c2914))
* **example:** Bump the dependencies group in /examples/nextjs-13-pages-wrap with 1 update ([#366](#366)) ([62a3e7f](62a3e7f))
* **example:** Bump the dependencies group in /examples/nextjs-13-pages-wrap with 3 updates ([#332](#332)) ([5083415](5083415))
* **example:** Bump the dependencies group in /examples/nextjs-14-app-dir-rl with 1 update ([#348](#348)) ([29b2259](29b2259))
* **example:** Bump the dependencies group in /examples/nextjs-14-app-dir-rl with 1 update ([#361](#361)) ([291ad58](291ad58))
* **example:** Bump the dependencies group in /examples/nextjs-14-app-dir-rl with 3 updates ([#330](#330)) ([505c886](505c886))
* **example:** Bump the dependencies group in /examples/nextjs-14-app-dir-validate-email with 1 update ([#352](#352)) ([ce76dcb](ce76dcb))
* **example:** Bump the dependencies group in /examples/nextjs-14-app-dir-validate-email with 1 update ([#358](#358)) ([71847b9](71847b9))
* **example:** Bump the dependencies group in /examples/nextjs-14-app-dir-validate-email with 3 updates ([#326](#326)) ([322311e](322311e))
* **example:** Bump the dependencies group in /examples/nextjs-14-clerk-rl with 1 update ([#349](#349)) ([1f4e1d4](1f4e1d4))
* **example:** Bump the dependencies group in /examples/nextjs-14-clerk-rl with 1 update ([#362](#362)) ([2d3f8eb](2d3f8eb))
* **example:** Bump the dependencies group in /examples/nextjs-14-clerk-rl with 3 updates ([#329](#329)) ([3797b6b](3797b6b))
* **example:** Bump the dependencies group in /examples/nextjs-14-clerk-shield with 1 update ([#357](#357)) ([e35d530](e35d530))
* **example:** Bump the dependencies group in /examples/nextjs-14-clerk-shield with 3 updates ([#327](#327)) ([12cf78b](12cf78b))
* **example:** Bump the dependencies group in /examples/nextjs-14-decorate with 1 update ([#350](#350)) ([51a21cf](51a21cf))
* **example:** Bump the dependencies group in /examples/nextjs-14-decorate with 1 update ([#354](#354)) ([4267d44](4267d44))
* **example:** Bump the dependencies group in /examples/nextjs-14-decorate with 3 updates ([#331](#331)) ([2641ffe](2641ffe))
* **example:** Bump the dependencies group in /examples/nextjs-14-openai with 1 update ([#360](#360)) ([cc7f381](cc7f381))
* **example:** Bump the dependencies group in /examples/nextjs-14-openai with 2 updates ([#346](#346)) ([a5db5a9](a5db5a9))
* **example:** Bump the dependencies group in /examples/nextjs-14-openai with 4 updates ([#328](#328)) ([d927ecc](d927ecc))
* **example:** Bump the dependencies group in /examples/nextjs-14-pages-wrap with 1 update ([#347](#347)) ([adb1a83](adb1a83))
* **example:** Bump the dependencies group in /examples/nextjs-14-pages-wrap with 1 update ([#355](#355)) ([aca306b](aca306b))
* **example:** Bump the dependencies group in /examples/nextjs-14-pages-wrap with 3 updates ([#325](#325)) ([2bbf20d](2bbf20d))
* **example:** Bump the dependencies group in /examples/nextjs-example with 1 update ([#324](#324)) ([4bf8997](4bf8997))
* Update trunk and linter ([#363](#363)) ([b6ab8a6](b6ab8a6))


### 📝 Documentation

* **examples:** Add Node.js express server validate email example ([#343](#343)) ([fc6c6a8](fc6c6a8))
* **examples:** Added Node.js Express server example ([#333](#333)) ([f398c28](f398c28))


### 🧹 Miscellaneous Chores

* **analyze:** Replace node import with crypto global ([#335](#335)) ([bcc27f2](bcc27f2))
* **ci:** Ensure dependabot doesn't update next to 14 in 13 example ([#364](#364)) ([32e4cc7](32e4cc7))
* **examples:** Leverage semver so next gets updated by dependabot ([#345](#345)) ([58b6d2e](58b6d2e))
* Make next a peerDep in our eslint package ([#344](#344)) ([89de5a8](89de5a8))
* Switch Next.js to peer dependency ([#339](#339)) ([cb82883](cb82883))
</details>

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Next.js a peerDep
2 participants