feat: compatible with server menus #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyggod
reviewed
Jun 13, 2022
Comment on lines
+21
to
+25
| if ( | ||
| !appStore.appAsyncMenus.length && | ||
| !WHITE_LIST.find((el) => el.name === to.name) | ||
| ) { | ||
| await appStore.fetchServerMenuConfig(); |
There was a problem hiding this comment.
我理解主要做的事还是这L21~L25这五行？其他的没太理解，只是将守卫给统一了，不单独做server menu的守卫了吗？
There was a problem hiding this comment.
先说明一下这5行。主要是一些场景的处理，比如进入'login', 'notFound'这些页面就没必要去进行请求了。算是一个场景优化。其余的调整主要是针对流程上的梳理，先针对用户是否登录进行处理，再对页面进行鉴权。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Background and context
#117
Solution
How is the change tested?
Changelog
Checklist:
featurebranch and others should be submitted tomasterbranch)Other information