Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add virtualenv support to the ZSH prompt #285

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add virtualenv support to the ZSH prompt #285

wants to merge 1 commit into from

Conversation

duganchen
Copy link

This adds support for Python's Virtual environments to the ZSH prompt.

So far, I've updated only the code (it works). I want to see if there's interest in merging this before I update the comments and documentation.

@arcticicestudio
Copy link
Owner

Hi @duganchen 👋, thanks for your contribution 👍
Even though I appreciate every help I don't want to merge this one. The reason is that these are my personal .files and I try to avoid anything related to scripting languages like Python.
I also like to keep my prompt as simple as possible without introducing any "clutter" or fill it up with tons of features that have only little benefit or are never used. I know many users got used to shell/prompt bootstrap projects like "Oh My ZSH" or spaceship that come with many features likes this, but keeping it simple is a great way to keep focus on the important parts.

Anyway, this is open source and you can simply use it for your own setup. One way to improve this PR is to use ZSH's condition syntax instead of an empty VENV variable:

(?..${VENV})

Thanks again for your effort to create this PR. Rejecting a PR is one of the harder parts as a project maintainer so I hope you understand my points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants