Skip to content

Commit

Permalink
Global tool/dependency managing with gobin (#91)
Browse files Browse the repository at this point in the history 
In GH-82 and GH-88, two workarounds have been implemented in order to
prevent the "pollution" of the project Go module file due to development
tools and dependencies when installed through `go get`.
The workaround to install modules/packages outside of the project root
directory (preventing the Go toolchain to pick up the `$GOMOD`
environment variable initialized with the path to the projects Go module
file) works, but might result in problems due to already installed
executables with different versions.

The general problem of tool dependencies a a long-time known issue/weak
point of the current Go toolchain and is a highly rated change request
from the Go community [1,2].

The official Go GitHub repository wiki provides a section on "How can I
track tool dependencies for a module?" [3] that describes a workaround
that tracks tool dependencies through the Go module logic via a
`tools.go` file with a dedicated `tools` build tag to prevent these
modules to be included in production binary artifact builds.
This approach works fine for non-main packages, but for CLI tools that
are only implemented in the `main` package can not be imported in such
a file.

In order to tackle this problem, a user from the community implemented
`gobin` [4], "an experimental, module-aware command to install/run main
packages".
It allows to install or run main-package commands without "polluting"
the Go module file by default. It downloads modules in version-aware
mode into a binary cache path within the system's cache
directory (`os.UserCacheDir()` [5]). It can be used to query for the
path of the executable for a given module/package to simplify the usage
from within Mage.
It prevents problems due to already installed global binaries in
`$GOPATH`/`$GOBIN` by using a cache directory instead. This keeps the
system clean and ensures the correct version of a module executable is
already used.

`gobin` is still in an early development state, but has already received
a lot of positive feedback and is used in many projects. There are also
many members of the core Go team that are contributing to the project
and the chance is high that it will influence the official future Go
toolchain implementation or might be partially ported.
Also see gobin's FAQ page in the repository wiki [6] for more details.

To finally manage the tool dependency problem for snowsaw, `gobin` has
been integrated into the Mage build toolchain.

[1]: golang/go#25922
[2]: golang/go#27653
[3]: https://github.com/golang/go/wiki/Modules#how-can-i-track-tool-dependencies-for-a-module
[4]: https://github.com/myitcv/gobin
[5]: https://golang.org/pkg/os/#UserCacheDir
[6]: https://github.com/myitcv/gobin/wiki/FAQ

Relates to GH-82
Relates to GH-88
Resolves GH-90
  • Loading branch information
@arcticicestudio
arcticicestudio authored Oct 17, 2019
1 parent 213111d commit ad91191
Show file tree
Hide file tree
Showing 2 changed files with 131 additions and 59 deletions.
2 changes: 1 addition & 1 deletion .golangci.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -79,4 +79,4 @@ run:
deadline: 15m

service:
golangci-lint-version: 1.17.x
golangci-lint-version: 1.19.x
188 changes: 130 additions & 58 deletions magefile.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,14 @@ import (

// buildDependency represents a build dependency like a tool used to build or develop the project.
type buildDependency struct {
// The path of the binary executable.
// BinaryExecPath is the path of the binary executable.
BinaryExecPath string
// The name of the binary.
// BinaryName is the name of the binary.
BinaryName string
// The name of the package.
PackageName string
// ModuleName is the name of the module.
ModuleName string
// ModuleVersion is the version of the module including prefixes like "v" if any.
ModuleVersion string
}

const (
Expand Down Expand Up @@ -83,14 +85,33 @@ var (
// See https://github.com/mitchellh/gox for more details.
crossCompileTool = &buildDependency{
BinaryName: "gox",
PackageName: "github.com/mitchellh/gox@v1.0.1",
ModuleName: "github.com/mitchellh/gox",
ModuleVersion: "v1.0.1",
}

// devToolManager is the tool to install and run all used project tools and applications with Go's module mode.
// This is necessary because the Go toolchain currently doesn't support the handling of local or global project tool
// dependencies in module mode without "polluting" the project's Go module file (go.mod).
//
// See the FAQ/documentations of "gobin" as well as issue references for more details about the tool and its purpose:
// https://github.com/myitcv/gobin/wiki/FAQ
//
// For more details about the status of proposed official Go toolchain solutions and workarounds see the following
// references:
// - https://github.com/golang/go/wiki/Modules#how-can-i-track-tool-dependencies-for-a-module
// - https://github.com/golang/go/issues/27653
// - https://github.com/golang/go/issues/25922
devToolManager = &buildDependency{
BinaryName: "gobin",
ModuleName: "github.com/myitcv/gobin",
ModuleVersion: "v0.0.13",
}

// The tool used to format all Go source files.
// See https://godoc.org/golang.org/x/tools/cmd/goimports for more details.
formatTool = &buildDependency{
PackageName: "golang.org/x/tools/cmd/goimports",
BinaryName: "goimports",
ModuleName: "golang.org/x/tools/cmd/goimports",
}

// Arguments for the `-gcflags` flag to pass on each `go tool compile` invocation.
Expand All @@ -110,8 +131,9 @@ var (
// This is the same tool used by the https://golangci.com service that is also integrated in snowsaw's CI/CD pipeline.
// See https://github.com/golangci/golangci-lint for more details.
lintTool = &buildDependency{
PackageName: "github.com/golangci/golangci-lint/cmd/golangci-lint@v1.19.1",
BinaryName: "golangci-lint",
ModuleName: "github.com/golangci/golangci-lint/cmd/golangci-lint",
ModuleVersion: "v1.19.1",
}

// The output directory for reports like test coverage.
Expand Down Expand Up @@ -149,9 +171,14 @@ func init() {
goPath = value
}

// Bootstrap bootstraps the local development environment by installing the required tools and build dependencies.
func Bootstrap() {
mg.SerialDeps(bootstrap)
}

// Build compiles the project in development mode for the current OS and architecture type.
func Build() {
mg.SerialDeps(Clean, compile)
mg.SerialDeps(clean, compile)
}

// Clean removes previous development and distribution builds from the project root.
Expand All @@ -164,42 +191,42 @@ func Clean() {
// version information via LDFLAGS.
// Run `strings <PATH_TO_BINARY> | grep "$PWD"` to verify that all paths have been successfully stripped.
func Dist() {
mg.SerialDeps(Clean, validateBuildDependencies, compileProd)
mg.SerialDeps(validateDevTools, clean, compileProd)
}

// DistCrossPlatform builds the project in production mode for cross-platform distribution.
// This includes all steps from the current platform distribution/production task `Dist`,
// but instead builds for all configured OS/architecture types.
func DistCrossPlatform() {
mg.SerialDeps(Clean, validateBuildDependencies, compileProdCross)
mg.SerialDeps(validateDevTools, clean, compileProdCross)
}

// DistCrossPlatformOpt builds the project in production mode for cross-platform distribution with optimizations.
// This includes all steps from the cross-platform distribution task `DistCrossPlatform` and additionally removes all
// debug metadata to shrink the memory overhead and file size as well as reducing the chance for possible security
// related problems due to enabled development features and leaked debug information.
func DistCrossPlatformOpt() {
mg.SerialDeps(Clean, validateBuildDependencies, compileProdCrossOpt)
mg.SerialDeps(validateDevTools, clean, compileProdCrossOpt)
}

// DistOpt builds the project in production mode with optimizations like minification and debug symbol stripping.
// This includes all steps from the production build task `Dist` and additionally removes all debug metadata to shrink
// the memory overhead and file size as well as reducing the chance for possible security related problems due to
// enabled development features and leaked debug information.
func DistOpt() {
mg.SerialDeps(Clean, validateBuildDependencies, compileProdOpt)
mg.SerialDeps(validateDevTools, clean, compileProdOpt)
}

// Format searches all project Go source files and formats them according to the Go code styleguide.
func Format() {
mg.SerialDeps(validateBuildDependencies, runGoImports)
mg.SerialDeps(validateDevTools, runGoImports)
}

// Lint runs all linters configured and executed through `golangci-lint`.
// See the `.golangci.yml` configuration file and official GolangCI documentations at https://golangci.com
// and https://github.com/golangci/golangci-lint for more details.
func Lint() {
mg.SerialDeps(validateBuildDependencies, runGolangCILint)
mg.SerialDeps(validateDevTools, runGolangCILint)
}

// Test runs all unit tests with enabled race detection.
Expand All @@ -209,7 +236,7 @@ func Test() {

// TestCover runs all unit tests with with coverage reports and enabled race detection.
func TestCover() {
mg.SerialDeps(Clean)
mg.SerialDeps(clean)
// Ensure the required directory structure exists, `go test` doesn't create it automatically.
createDirectoryStructure(reportsDir)
testCoverageProfileFlag = fmt.Sprintf("-coverprofile=%s", filepath.Join(reportsDir, testCoverageOutputFileName))
Expand All @@ -221,6 +248,55 @@ func TestIntegration() {
mg.SerialDeps(integrationTests)
}

func bootstrap() {
prt.Infof("Bootstrapping development tool/dependency manager %s",
color.CyanString("%s@%s", devToolManager.ModuleName, devToolManager.ModuleVersion))
cmdInstallGobin := exec.Command(goExec, "get", "-u",
fmt.Sprintf("%s@%s", devToolManager.ModuleName, devToolManager.ModuleVersion))
// Run the installation outside of the project root directory to prevent the pollution of the project's Go module
// file.
// This is a necessary workaround until the Go toolchain is able to install packages globally without
// updating the module file when the "go get" command is run from within the project root directory.
// See https://github.com/golang/go/issues/30515 for more details or more details and proposed solutions
// that might be added to Go's build tools in future versions.
cmdInstallGobin.Dir = os.TempDir()
cmdInstallGobin.Env = os.Environ()
// Explicitly enable "module" mode when installing the dev tool manager to allow to use pinned module version.
cmdInstallGobin.Env = append(cmdInstallGobin.Env, "GO111MODULE=on")
if gobinInstallErr := cmdInstallGobin.Run(); gobinInstallErr != nil {
prt.Errorf("Failed to install required development tool/dependency manager %s:\n %s",
color.CyanString("%s@%s", devToolManager.ModuleName, devToolManager.ModuleVersion),
color.RedString("%s", gobinInstallErr))
os.Exit(1)
}

prt.Infof("Bootstrapping required development tools/dependencies:")
for _, bd := range []*buildDependency{crossCompileTool, formatTool, lintTool} {
modulePath := bd.ModuleName
// If the non-module dependency is not installed yet, install it normally into the $GOBIN path,...
if bd.ModuleVersion == "" {
fmt.Println(color.CyanString(" %s", modulePath))
if installErr := sh.Run(devToolManager.BinaryName, "-u", modulePath); installErr != nil {
prt.Errorf("Failed to install required development tool/dependency %s:\n %s",
color.CyanString(modulePath), color.RedString("%s", installErr))
os.Exit(1)
}
continue
}

// ...otherwise install into "gobin" binary cache.
modulePath = fmt.Sprintf("%s@%s", bd.ModuleName, bd.ModuleVersion)
fmt.Println(color.CyanString(" %s", modulePath))
if installErr := sh.Run(devToolManager.BinaryName, "-u", modulePath); installErr != nil {
prt.Errorf("Failed to install required development tool/dependency %s:\n %s",
color.CyanString(modulePath), color.RedString("%s", installErr))
os.Exit(1)
}
}

prt.Successf("Successfully bootstrapped required development tools/dependencies")
}

func clean() {
if err := os.RemoveAll(buildDir); err != nil {
prt.Errorf("Failed to clean up project directory: %v", err)
Expand Down Expand Up @@ -326,17 +402,17 @@ func getEnvFlags() map[string]string {
"Injecting %s:\n"+
" Build Date: %s\n"+
" Version: %s",
color.CyanString("LDFLAGS"), color.CyanString(buildDate), color.CyanString(strings.Join(version, "-")))
color.BlueString("LDFLAGS"), color.CyanString(buildDate), color.CyanString(strings.Join(version, "-")))

prt.Infof(
"Injecting %s:\n"+
" -trimpath: %s",
color.CyanString("ASMFLAGS"), color.CyanString(pwd))
color.BlueString("ASMFLAGS"), color.CyanString(pwd))

prt.Infof(
"Injecting %s:\n"+
" -trimpath: %s",
color.CyanString("GCFLAGS"), color.CyanString(pwd))
color.BlueString("GCFLAGS"), color.CyanString(pwd))

return map[string]string{
"BUILD_DATE_TIME": buildDate,
Expand All @@ -345,6 +421,15 @@ func getEnvFlags() map[string]string {
"VERSION": strings.Join(version, "-")}
}

// getExecutablePath returns the path to the executable for the given package/module.
// When the "resolveWithGobin" parameter is set to true, the path will be resolved from the "gobin" binary cache.
func getExecutablePath(name string, resolveWithGobin bool) (string, error) {
if resolveWithGobin {
return sh.Output(devToolManager.BinaryName, "-p", "-nonet", name)
}
return exec.LookPath(name)
}

// prepareBuildTags reads custom build tags defined by the user through the `SNOWSAW_BUILD_TAGS` environment
// variable and appends them together with all additionally passed tags to the global `tags` slice.
// Returns `true` if custom build tags have been loaded, `false` otherwise.
Expand Down Expand Up @@ -461,50 +546,37 @@ func runGox(envFlags map[string]string, buildFlags ...string) {
prt.Successf("Cross compilation completed successfully with output to %s directory", color.GreenString(buildDir))
}

// validateBuildDependencies checks if all required build dependencies are installed, the binaries are available in
// PATH and will try to install them if not passing the checks.
func validateBuildDependencies() {
// validateDevTools validates that all required development tool/dependency executables are bootstrapped and
// available in PATH or "gobin" binary cache.
func validateDevTools() {
prt.Infof("Verifying development tools/dependencies")
handleError := func(name string, err error) {
prt.Errorf("Failed do determine development tool/dependency %s:\n%s",
color.CyanString(name), color.RedString(" %s", err))
prt.Warnf("Run the %s task to install all required tools/dependencies!", color.YellowString("bootstrap"))
os.Exit(1)
}

gobinPath, checkGobinPathErr := getExecutablePath(devToolManager.BinaryName, false)
if checkGobinPathErr != nil {
handleError(fmt.Sprintf("%s@%s", devToolManager.ModuleName, devToolManager.ModuleVersion), checkGobinPathErr)
}
devToolManager.BinaryExecPath = gobinPath

for _, bd := range []*buildDependency{crossCompileTool, formatTool, lintTool} {
binPath, err := exec.LookPath(bd.BinaryName)
if err == nil {
bd.BinaryExecPath = binPath
prt.Infof("Required build dependency %s already installed: %s",
color.CyanString(bd.PackageName),
color.BlueString(bd.BinaryExecPath))
if bd.ModuleVersion == "" {
p, e := getExecutablePath(bd.BinaryName, false)
if e != nil {
handleError(bd.ModuleName, e)
}
bd.BinaryExecPath = p
continue
}

prt.Infof("Installing required build dependency: %s", color.CyanString(bd.PackageName))
c := exec.Command(goExec, "get", "-u", bd.PackageName)
// Run installations outside of the project root directory to prevent the pollution of the project's Go module
// file.
// This is a necessary workaround until the Go toolchain is able to install packages globally without
// updating the module file when the "go get" command is run from within the project root directory.
// See https://github.com/golang/go/issues/30515 for more details or more details and proposed solutions
// that might be added to Go's build tools in future versions.
c.Dir = os.TempDir()
c.Env = os.Environ()
// Explicitly enable "module" mode to install development dependencies to allow to use pinned module versions.
env := map[string]string{"GO111MODULE": "on"}
for k, v := range env {
c.Env = append(c.Env, k+"="+v)
}
if err = c.Run(); err != nil {
prt.Errorf("Failed to install required build dependency %s: %v", color.CyanString(bd.PackageName), err)
prt.Warnf("Please install manually: %s", color.CyanString("go get -u %s", bd.PackageName))
os.Exit(1)
}

binPath, err = exec.LookPath(bd.BinaryName)
if err != nil {
bd.BinaryExecPath = binPath
prt.Errorf("Failed to find executable path of required build dependency %s after installation: %v",
color.CyanString(bd.PackageName), err)
os.Exit(1)
p, e := getExecutablePath(fmt.Sprintf("%s@%s", bd.ModuleName, bd.ModuleVersion), true)
if e != nil {
handleError(fmt.Sprintf("%s@%s", bd.ModuleName, bd.ModuleVersion), e)
}
bd.BinaryExecPath = binPath
prt.Infof("Using executable %s of installed build dependency %s",
color.CyanString(bd.BinaryExecPath),
color.BlueString(bd.PackageName))
bd.BinaryExecPath = p
}
}

0 comments on commit ad91191

Please sign in to comment.