Move learning_objective boiler plate to overview and feedback macros#927
Merged
Move learning_objective boiler plate to overview and feedback macros#927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I moved the text "After completion of this module, learners will be able to:" out of each module's individual
learning_objectivesmacro and into theoverviewandfeedbackmacros, which is where the LOs are currently printed.This PR is a minor change in the sense that there are no edits that will affect learners' experience of modules, but it is a major change in that it touches every published module file, as well as the
overviewandfeedbackmacros, docs.md, and all three templates.Note that we informally discussed maybe changing the wording before printing LOs, especially in the feedback section to something other than "After completion of this module, learners will be able to:" but that is not part of this PR. In future, we can make changes like that more easily, since it will be an edit in just macros.md rather than needing to edit each module file.