-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for IAsyncEnumerable #175 #176
Conversation
Can you add any tests or something in the sample demonstrating its usage? |
I just added tests and a sample endpoint. |
@@ -19,7 +19,10 @@ | |||
</ItemGroup> | |||
|
|||
<ItemGroup> | |||
<ProjectReference Include="..\SampleEndpointApp\SampleEndpointApp.csproj" /> | |||
<ProjectReference Include="..\..\src\Ardalis.ApiEndpoints\Ardalis.ApiEndpoints.csproj"> | |||
<SetTargetFramework>TargetFramework=netstandard2.1</SetTargetFramework> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this be an issue for NuGet consumers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it makes sense to migrate whole package to netstandard2.1
. It's only intended to be used in ASP.NET Core anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this be an issue for NuGet consumers?
I remember reading something about it, but did not have time to try.
Maybe it makes sense to migrate whole package to
netstandard2.1
. It's only intended to be used in ASP.NET Core anyway
I would personally like to upgrade to netstandard2.1.
The compatibility table is here:
https://docs.microsoft.com/en-us/dotnet/standard/net-standard?tabs=net-standard-2-1#select-net-standard-version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ardalis How about updating to netstandard2.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ardalis any thoughts about upgrading to netstandard2.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that's fine with me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#180 has bumped the target framework to netcore3.1, so I removed the netstandard2.1 stuff.
code is so much cleaner now :)
Solves #175
IAsyncEnumerable
is only available since netstandard2.1.So I made the
EndpointBase
classes partial, added a new partial class file and removed it from compilation when the targetframework is not netstandard2.1What I was not sure of, is how to add test for this feature.