Update TryFromName method #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ardalis
approved these changes
Oct 1, 2020
This was referenced Nov 9, 2025
Package Dependencies: Bump Ardalis.SmartEnum from 7.0.0 to 8.2.0
hamadoumana/msvc-product-net-core#6
Closed
Closed
Closed
Closed
This was referenced Nov 19, 2025
Closed
Closed
This was referenced Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix that changes the
TryFromNamebehavior so it returns false when the name is null or empty instead of throwing an error. However, it should be considered as breaking change so it might be better to bump the major version number.Also, the PR contains a few unit tests that cover
TryFromNameThis PR resolves #95