Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use graphql-tools-fork #460

Merged
merged 2 commits into from
Mar 11, 2020
Merged

use graphql-tools-fork #460

merged 2 commits into from
Mar 11, 2020

Conversation

yaacovCR
Copy link
Contributor

@yaacovCR yaacovCR commented Feb 6, 2020

Required fix released in graphql-tools-fork v8.5.2

@ardatan
Copy link
Owner

ardatan commented Feb 6, 2020

Thank you! I need to trigger CI for this PR to make sure tests pass for both v14 and v15.

@ardatan
Copy link
Owner

ardatan commented Feb 14, 2020

@yaacovCR Could you update your PR with latest changes because I fixed something related to CI? I want to see if this PR works with v15 because I don't think it does.

@yaacovCR
Copy link
Contributor Author

graphql-tools-fork v8.6.2 is tested with graphql v0.12 and above.

The fork may or may not work with v0.9-v0.11.

I am not sure if the upstream graphql-tools works from v0.9-0.11. Currently, the upstream repository tests fail on upstream graphql-tools for anything below v0.13. For the fork, I fixed the tests for v0.12 by adding the necessary polyfills, as that is what Apollo Server apparently supports (see ardatan/graphql-tools#1284), but did not go back further.

@yaacovCR
Copy link
Contributor Author

@ardatan I removed changes to peerDependency requirement, but I have not confirmed the status of this repository, upstream graphql-tools, or graphql-tools-fork with graphql v0.8-v0.11

@darkbasic
Copy link
Collaborator

I support this: the official graphql-tools library is broken in so many ways, sometimes completely unrelated to schema stitching. It's not even possible to follow the official Apollo docs without unveiling some nasty bugs: ardatan/graphql-tools#1265

@ardatan ardatan merged commit 5155a05 into ardatan:master Mar 11, 2020
@ardatan
Copy link
Owner

ardatan commented Mar 11, 2020

Thank you @yaacovCR !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants