code always INTERNAL_SERVER_ERROR when using mergeSchemas

[ph55]

Seems that #925 not completely fixed.
I'm using graphql-middleware and when throwing error the code is always INTERNAL_SERVER_ERROR.

Reproduction:

import { applyMiddleware } from 'graphql-middleware';
import { mergeSchemas } from 'graphql-tools';
import { AuthenticationError } from 'apollo-server-errors';

// ...
const errored = () => {
    throw new AuthenticationError('Not allowed');
};

const middleware = {
    User: {
      phone: errored
    }
};
//...
schema = applyMiddleware(schema, middleware);
schema = mergeSchemas({ schemas: [schema] });
// ...

Result with trace:

{
  "errors": [
    {
      "message": "Not allowed",
      "locations": [
        {
          "line": 5,
          "column": 5
        }
      ],
      "path": [
        "user",
        "phone"
      ],
      "extensions": {
        "code": "INTERNAL_SERVER_ERROR",
        "exception": {
          "stacktrace": [
            "Error: Not allowed",
            "    at defaultMergedResolver (/app/node_modules/graphql-tools/src/stitching/defaultMergedResolver.ts:18:24)",
            "    at field.resolve (/app/node_modules/graphql-tools/src/stitching/mergeSchemas.ts:263:16)",
            "    at field.resolve (/app/node_modules/graphql-extensions/src/index.ts:267:18)",
            "    at resolveFieldValueOrError (/app/node_modules/graphql/execution/execute.js:479:18)",
            "    at resolveField (/app/node_modules/graphql/execution/execute.js:446:16)",
            "    at executeFields (/app/node_modules/graphql/execution/execute.js:293:18)",
            "    at collectAndExecuteSubfields (/app/node_modules/graphql/execution/execute.js:717:10)",
            "    at completeObjectValue (/app/node_modules/graphql/execution/execute.js:707:10)",
            "    at completeValue (/app/node_modules/graphql/execution/execute.js:598:12)",
            "    at /app/node_modules/graphql/execution/execute.js:500:16"
          ]
        }
      }
    }
  ],
  "data": {
    "user": {
      "id": 1,
      "email": "a@b.kek",
      "phone": null
    }
  }
}

After removing mergeSchemas , error code returned as expected:

{
  "errors": [
    {
      "message": "Not allowed",
      "locations": [
        {
          "line": 5,
          "column": 5
        }
      ],
      "path": [
        "user",
        "phone"
      ],
      "extensions": {
        "code": "UNAUTHENTICATED",
        "exception": {
          "stacktrace": [
            "AuthenticationError: Not allowed",
            "    at errored (/app/src/@core/graphql/graphql-middleware/graphql-middleware.service.ts:12:13)",
            "    at /app/node_modules/graphql-middleware/src/applicator.ts:32:5",
            "    at field.resolve (/app/node_modules/graphql-extensions/src/index.ts:267:18)",
            "    at resolveFieldValueOrError (/app/node_modules/graphql/execution/execute.js:479:18)",
            "    at resolveField (/app/node_modules/graphql/execution/execute.js:446:16)",
            "    at executeFields (/app/node_modules/graphql/execution/execute.js:293:18)",
            "    at collectAndExecuteSubfields (/app/node_modules/graphql/execution/execute.js:717:10)",
            "    at completeObjectValue (/app/node_modules/graphql/execution/execute.js:707:10)",
            "    at completeValue (/app/node_modules/graphql/execution/execute.js:598:12)",
            "    at /app/node_modules/graphql/execution/execute.js:500:16"
          ]
        }
      }
    }
  ],
  "data": {
    "user": {
      "id": 1,
      "email": "a@b.kek",
      "phone": null
    }
  }
}

[arc-008]

@ph55 I had similar issue while merging remote schemas. I have imported "extractExtensionDefinitions" from "graphql-tools" (4.0.3) to resolve. Not sure about your scenario though.

[asoet]

@8arcturus how/where did you use extractExtensionDefinitions? Only importing "extractExtensionDefinitions" doesn't have any effect. No sure how to use it.

My problem extensions are removed when there are multiple errors. They are combined to one error. It's probably an extensions to this problem

[hwillson]

Here's a runnable reproduction that demonstrates this issue:
https://github.com/hwillson/graphql-tools-stitching-errors

I'm working on a fix now, and will have it ready shortly.

[gajus]

Is there a workaround for this at the moment?

[yaacovCR]

Rolled into #1306