-
-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't get correct types extending SchemaDirectiveVisitor #1298
Comments
Fold into #1306 |
kamilkisiela
added a commit
that referenced
this issue
Apr 1, 2020
kamilkisiela
added a commit
that referenced
this issue
Apr 1, 2020
kamilkisiela
added a commit
that referenced
this issue
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue
Couldn't get correct types when i wrote own directive handler.
If i extend from SchemaDirectiveVisitor
class MyDirective extends SchemaDirectiveVisitor
this.args is always resolved by typescript as {[name: string]: any;}
Suggestion
Rewrite SchemaDirectiveVisitor as Generic to provide args, context and schema types for inherited classes
The text was updated successfully, but these errors were encountered: