[BUG: mocks] Default resolvers are called incorrectly #1807
Comments
|
I definitely see your point! As this bug is quite old, I am not sure if this unusual behavior is relied upon by the remainder of the mock code. Crazy busy at the moment, but a PR that shows no other failing tests would be greatly appreciated. |
|
Ok, I will try to create PR. |
Merged
yaacovCR
added
the
waiting-for-release
|
fixed in v7 |
yaacovCR
added a commit
that referenced
this issue
Oct 6, 2020
resolvers that return 'subresolvers' or fields that are set to functions for later use as resolvers were behaving not according to upstream graphql-js convention, these functions take 3 arguments, not 4, with parent available as this. See #1807 See https://github.com/graphql/graphql-js/blob/7e79bbe5f2b0e971b5e5f6fe3e7b19c43dea9f35/src/execution/execute.js#L1210-L1212
yaacovCR
added a commit
that referenced
this issue
Oct 6, 2020
resolvers that return 'subresolvers' or fields that are set to functions for later use as resolvers were behaving not according to upstream graphql-js convention, these functions take 3 arguments, not 4, with parent available as this. See #1807 See https://github.com/graphql/graphql-js/blob/7e79bbe5f2b0e971b5e5f6fe3e7b19c43dea9f35/src/execution/execute.js#L1210-L1212
|
Awesome 🥳 Thanks. |
|
Will leave open until release. Thanks for reporting. |
yaacovCR
added a commit
that referenced
this issue
Oct 23, 2020
resolvers that return 'subresolvers' or fields that are set to functions for later use as resolvers were behaving not according to upstream graphql-js convention, these functions take 3 arguments, not 4, with parent available as this. See #1807 See https://github.com/graphql/graphql-js/blob/7e79bbe5f2b0e971b5e5f6fe3e7b19c43dea9f35/src/execution/execute.js#L1210-L1212
|
Released in v7 |
yaacovCR
removed
bug
waiting-for-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Looks like mock is using the incorrect parameters when it is calling the default resolver.
graphql-tools/packages/mock/src/mocking.ts
Line 127 in df52bf8
When the object already contains the field and if that field is a function, then it should be called without the
rootparameter.graphql-jsis already doing that as described here.Also, as
apollo-serveris using this package (a slightly outdated), enabling mocks will broke these "inline" subresolvers. See apollographql/apollo-server#4398 to see it in action.The text was updated successfully, but these errors were encountered: