Serialize enum argument values in AddArgumentsAsVariables #1075
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
AddArgumentsAsVariables
transform currently takes the variable values directly fromargs
. This PR serializes allGraphQLEnumType
argument values before, so that the variable value contains the enum key, not the internal enum value. This avoids errors with merged schemas.Not sure if the same thing should also be done with custom scalars(???) I left those alone since I got a bit confused there - the
serialize
/parseValue
/parseLiteral
methods don't seem to be carried over in schema merging (becausekeepResolvers
will always befalse
inrecreateType
???)EDIT (07/18): This has been merged into
graphql-tools-fork
with additional fixes for custom scalars by @yaacovCR - thanks!