Make TypeVisitor result type nullable #1212
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeVisitor
is expected to returnGraphQLNamedType | null | undefined
in the code herehttps://github.com/apollographql/graphql-tools/blob/9bfb11c51e2ca57579a950bd8de65adb0e1f37a3/src/transforms/visitSchema.ts#L60
However, it is declared as non-nullable here
https://github.com/apollographql/graphql-tools/blob/9bfb11c51e2ca57579a950bd8de65adb0e1f37a3/src/transforms/visitSchema.ts#L33-L36
Which leads to necessity of type cast when a null-returning visitor is defined.
TODO:
[ ] If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)[ ] Make sure all of the significant new logic is covered by tests