Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stitching from and to interfaces #1443

Merged
merged 5 commits into from
May 4, 2020
Merged

Fix stitching from and to interfaces #1443

merged 5 commits into from
May 4, 2020

Commits on May 4, 2020

  1. ExpandAbstractTypes to check transformed subschema 

    An abstract type may be present in the target schema, but renamed. ExpandAbstractTypes expands the abstract types not present in the target schema, but it should check the transformed target schema, to not be misled by renaming.

This may require manually passing the transformed schema in some cases. The default can stay to assume no renaming.

Within stitched schemas, the correct transformed schema can be saved to and then read from info.mergeInfo.transformedSchema.
    @yaacovCR
    yaacovCR committed May 4, 2020
    Configuration menu
    Copy the full SHA
    33e0503 View commit details
    Browse the repository at this point in the history

  2. move ICreateRequest to delegate package with ICreateRequestFromInfo

    @yaacovCR
    yaacovCR committed May 4, 2020
    Configuration menu
    Copy the full SHA
    0aaa006 View commit details
    Browse the repository at this point in the history

  3. Add WrapConcreteTypes transform 

    = fixes #751
    @yaacovCR
    yaacovCR committed May 4, 2020
    Configuration menu
    Copy the full SHA
    7a56bfc View commit details
    Browse the repository at this point in the history

  4. allow redelegation of nested root query fields 

    in some circumstances

nested root fields may not always successfully stitch to subschemas, for example when the root field is a new  abstract field stitching to a concrete field or the reverse
    @yaacovCR
    yaacovCR committed May 4, 2020
    Configuration menu
    Copy the full SHA
    9d8395e View commit details
    Browse the repository at this point in the history

  5. provide transformedSchema argument in more instances 

    = changes CreateResolverFn signature to take an options argument of type ICreateResolverOptions
    @yaacovCR
    yaacovCR committed May 4, 2020
    Configuration menu
    Copy the full SHA
    bce3e6a View commit details
    Browse the repository at this point in the history