Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get defer/stream from graphql-js #4796

Merged
merged 25 commits into from
Nov 1, 2022
Merged

get defer/stream from graphql-js #4796

merged 25 commits into from
Nov 1, 2022

Conversation

saihaj
Copy link
Collaborator

@saihaj saihaj commented Oct 28, 2022

Summary

Get Defer Stream support for execution based on graphql/graphql-js#3659. I think I can make incremental delivery default of this execute so no need to have special function. This executor is meant to support latest greatest features and be performant.

@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2022

🦋 Changeset detected

Latest commit: 71c9fd9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@graphql-tools/executor Patch
@graphql-tools/utils Major
@graphql-tools/delegate Patch
@graphql-tools/stitch Patch
@graphql-tools/batch-delegate Patch
@graphql-tools/batch-execute Patch
@graphql-tools/graphql-tag-pluck Patch
@graphql-tools/import Patch
@graphql-tools/links Patch
@graphql-tools/load Patch
@graphql-tools/merge Patch
@graphql-tools/mock Patch
@graphql-tools/node-require Patch
@graphql-tools/relay-operation-optimizer Patch
@graphql-tools/resolvers-composition Patch
@graphql-tools/schema Patch
@graphql-tools/stitching-directives Patch
@graphql-tools/wrap Patch
@graphql-tools/apollo-engine-loader Patch
@graphql-tools/code-file-loader Patch
@graphql-tools/git-loader Patch
@graphql-tools/github-loader Patch
@graphql-tools/graphql-file-loader Patch
@graphql-tools/json-file-loader Patch
@graphql-tools/module-loader Patch
@graphql-tools/prisma-loader Patch
@graphql-tools/url-loader Patch
federation-benchmark Patch
graphql-tools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@saihaj saihaj requested a review from ardatan October 28, 2022 21:05
@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2022

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 220       ✗ 0  
     data_received..................: 26 MB   2.5 MB/s
     data_sent......................: 94 kB   9.4 kB/s
     http_req_blocked...............: avg=9.48µs   min=2.5µs   med=3.8µs    max=611.7µs  p(90)=4.8µs    p(95)=5.1µs   
     http_req_connecting............: avg=4.89µs   min=0s      med=0s       max=538.6µs  p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=85.56ms  min=74.79ms med=80.79ms  max=206.45ms p(90)=93.56ms  p(95)=129.49ms
       { expected_response:true }...: avg=85.56ms  min=74.79ms med=80.79ms  max=206.45ms p(90)=93.56ms  p(95)=129.49ms
     http_req_failed................: 0.00%   ✓ 0         ✗ 110
     http_req_receiving.............: avg=188.43µs min=149.3µs med=170.35µs max=1.07ms   p(90)=186.21µs p(95)=222.05µs
     http_req_sending...............: avg=75.83µs  min=20.6µs  med=29.15µs  max=1.94ms   p(90)=40.51µs  p(95)=83.17µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=85.3ms   min=74.59ms med=80.56ms  max=205.31ms p(90)=93.36ms  p(95)=129.28ms
     http_reqs......................: 110     10.928705/s
     iteration_duration.............: avg=91.47ms  min=80.11ms med=86.12ms  max=212.41ms p(90)=102.48ms p(95)=135.01ms
     iterations.....................: 110     10.928705/s
     vus............................: 1       min=1       max=1
     vus_max........................: 1       min=1       max=1

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2022

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/batch-delegate 8.4.4-alpha-20221101140629-bcc8116c npm ↗︎ unpkg ↗︎
@graphql-tools/batch-execute 8.5.9-alpha-20221101140629-bcc8116c npm ↗︎ unpkg ↗︎
@graphql-tools/delegate 9.0.11-alpha-20221101140629-bcc8116c npm ↗︎ unpkg ↗︎
@graphql-tools/executor 0.0.3-alpha-20221101140629-bcc8116c npm ↗︎ unpkg ↗︎
@graphql-tools/graphql-tag-pluck 7.3.9-alpha-20221101140629-bcc8116c npm ↗︎ unpkg ↗︎
graphql-tools 8.3.9-alpha-20221101140629-bcc8116c npm ↗︎ unpkg ↗︎
@graphql-tools/import 6.7.9-alpha-20221101140629-bcc8116c npm ↗︎ unpkg ↗︎
@graphql-tools/links 8.3.15-alpha-20221101140629-bcc8116c npm ↗︎ unpkg ↗︎
@graphql-tools/load 7.8.3-alpha-20221101140629-bcc8116c npm ↗︎ unpkg ↗︎
@graphql-tools/apollo-engine-loader 7.3.16-alpha-20221101140629-bcc8116c npm ↗︎ unpkg ↗︎
@graphql-tools/code-file-loader 7.3.9-alpha-20221101140629-bcc8116c npm ↗︎ unpkg ↗︎
@graphql-tools/git-loader 7.2.9-alpha-20221101140629-bcc8116c npm ↗︎ unpkg ↗︎
@graphql-tools/github-loader 7.3.16-alpha-20221101140629-bcc8116c npm ↗︎ unpkg ↗︎
@graphql-tools/graphql-file-loader 7.5.8-alpha-20221101140629-bcc8116c npm ↗︎ unpkg ↗︎
@graphql-tools/json-file-loader 7.4.9-alpha-20221101140629-bcc8116c npm ↗︎ unpkg ↗︎
@graphql-tools/module-loader 7.2.9-alpha-20221101140629-bcc8116c npm ↗︎ unpkg ↗︎
@graphql-tools/prisma-loader 7.2.27-alpha-20221101140629-bcc8116c npm ↗︎ unpkg ↗︎
@graphql-tools/url-loader 7.16.7-alpha-20221101140629-bcc8116c npm ↗︎ unpkg ↗︎
@graphql-tools/merge 8.3.9-alpha-20221101140629-bcc8116c npm ↗︎ unpkg ↗︎
@graphql-tools/mock 8.7.9-alpha-20221101140629-bcc8116c npm ↗︎ unpkg ↗︎
@graphql-tools/node-require 6.4.11-alpha-20221101140629-bcc8116c npm ↗︎ unpkg ↗︎
@graphql-tools/relay-operation-optimizer 6.5.9-alpha-20221101140629-bcc8116c npm ↗︎ unpkg ↗︎
@graphql-tools/resolvers-composition 6.5.9-alpha-20221101140629-bcc8116c npm ↗︎ unpkg ↗︎
@graphql-tools/schema 9.0.7-alpha-20221101140629-bcc8116c npm ↗︎ unpkg ↗︎
@graphql-tools/stitch 8.7.16-alpha-20221101140629-bcc8116c npm ↗︎ unpkg ↗︎
@graphql-tools/stitching-directives 2.3.14-alpha-20221101140629-bcc8116c npm ↗︎ unpkg ↗︎
@graphql-tools/utils 9.0.0-alpha-20221101140629-bcc8116c npm ↗︎ unpkg ↗︎
@graphql-tools/wrap 9.2.6-alpha-20221101140629-bcc8116c npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2022

🚀 Website Preview

The latest changes to the website are available as preview in: https://3e0eabe3.graphql-tools.pages.dev

@ardatan ardatan force-pushed the saihaj/defer-stream branch 3 times, most recently from 323a496 to 3088ddf Compare October 29, 2022 20:22
@saihaj saihaj requested a review from ardatan October 31, 2022 19:49
@saihaj saihaj marked this pull request as ready for review October 31, 2022 19:49
@saihaj saihaj force-pushed the saihaj/defer-stream branch from 1acd73b to c7b9db4 Compare October 31, 2022 20:33
@ardatan ardatan force-pushed the saihaj/defer-stream branch from 5cc3d6c to 11f2458 Compare November 1, 2022 11:26
@ardatan ardatan merged commit 80836fa into master Nov 1, 2022
@ardatan ardatan deleted the saihaj/defer-stream branch November 1, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants