Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(executor): handle errors from the field subscriber #5187

Merged
merged 4 commits into from
Apr 18, 2023

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented Apr 18, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Apr 18, 2023

🦋 Changeset detected

Latest commit: 3c00764

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@graphql-tools/executor Patch
@graphql-tools/delegate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ardatan ardatan changed the title fix(executor): handle subscriber errors fix(executor): handle errors from the field subscriber Apr 18, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2023

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/delegate 9.0.32-alpha-20230418111547-3c007643 npm ↗︎ unpkg ↗︎
@graphql-tools/executor 0.0.18-alpha-20230418111547-3c007643 npm ↗︎ unpkg ↗︎
@graphql-tools/prisma-loader 7.2.71-alpha-20230418111547-3c007643 npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2023

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 250       ✗ 0  
     data_received..................: 29 MB   2.9 MB/s
     data_sent......................: 107 kB  11 kB/s
     http_req_blocked...............: avg=5.93µs   min=2.8µs   med=3.4µs   max=193.39µs p(90)=4.1µs    p(95)=4.65µs  
     http_req_connecting............: avg=1.15µs   min=0s      med=0s      max=144.6µs  p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=74.8ms   min=64.83ms med=71.1ms  max=192.96ms p(90)=81.4ms   p(95)=109.23ms
       { expected_response:true }...: avg=74.8ms   min=64.83ms med=71.1ms  max=192.96ms p(90)=81.4ms   p(95)=109.23ms
     http_req_failed................: 0.00%   ✓ 0         ✗ 125
     http_req_receiving.............: avg=159.48µs min=116.3µs med=136.3µs max=641.09µs p(90)=232.99µs p(95)=241.17µs
     http_req_sending...............: avg=92.58µs  min=17.1µs  med=23.7µs  max=2.41ms   p(90)=34.6µs   p(95)=595.15µs
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s      max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=74.55ms  min=64.69ms med=70.72ms max=192.44ms p(90)=80.84ms  p(95)=109.05ms
     http_reqs......................: 125     12.479027/s
     iteration_duration.............: avg=80.11ms  min=69.37ms med=76ms    max=197.9ms  p(90)=88.01ms  p(95)=114.75ms
     iterations.....................: 125     12.479027/s
     vus............................: 1       min=1       max=1
     vus_max........................: 1       min=1       max=1

@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2023

💻 Website Preview

The latest changes are available as preview in: https://0219b6f7.graphql-tools.pages.dev

@n1ru4l n1ru4l merged commit 91a895b into master Apr 18, 2023
@n1ru4l n1ru4l deleted the handle-subscribe-errors branch April 18, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants