Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(batch-delegate): respect the parent type name #5998

Merged
merged 4 commits into from
Apr 19, 2024
Merged

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented Mar 19, 2024

Copy link

changeset-bot bot commented Mar 19, 2024

🦋 Changeset detected

Latest commit: c96a095

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-tools/batch-delegate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ardatan ardatan changed the title fix(batch-delegate): respect the parent type name for the batch deleg… fix(batch-delegate): respect the parent type name Mar 19, 2024
Copy link
Contributor

github-actions bot commented Mar 19, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/batch-delegate 9.0.2-alpha-20240419160319-c96a095b29d85304f9f6871512eba6b9a3d328de npm ↗︎ unpkg ↗︎
@graphql-tools/federation 1.1.26-alpha-20240419160319-c96a095b29d85304f9f6871512eba6b9a3d328de npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented Mar 19, 2024

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 344       ✗ 0  
     data_received..................: 40 MB   4.0 MB/s
     data_sent......................: 147 kB  15 kB/s
     http_req_blocked...............: avg=4.09µs   min=2.16µs   med=2.72µs   max=197.22µs p(90)=3.82µs  p(95)=4.25µs  
     http_req_connecting............: avg=835ns    min=0s       med=0s       max=143.7µs  p(90)=0s      p(95)=0s      
     http_req_duration..............: avg=53.87ms  min=47.06ms  med=50.29ms  max=144.95ms p(90)=56.95ms p(95)=85.75ms 
       { expected_response:true }...: avg=53.87ms  min=47.06ms  med=50.29ms  max=144.95ms p(90)=56.95ms p(95)=85.75ms 
     http_req_failed................: 0.00%   ✓ 0         ✗ 172
     http_req_receiving.............: avg=141.48µs min=111.42µs med=136.15µs max=273.96µs p(90)=163.2µs p(95)=196.61µs
     http_req_sending...............: avg=25.06µs  min=16.52µs  med=23.57µs  max=60.49µs  p(90)=30.04µs p(95)=35.58µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s      p(95)=0s      
     http_req_waiting...............: avg=53.71ms  min=46.89ms  med=50.13ms  max=144.62ms p(90)=56.78ms p(95)=85.59ms 
     http_reqs......................: 172     17.183386/s
     iteration_duration.............: avg=58.17ms  min=50.52ms  med=54.38ms  max=149.09ms p(90)=61.99ms p(95)=89.9ms  
     iterations.....................: 172     17.183386/s
     vus............................: 1       min=1       max=1
     vus_max........................: 1       min=1       max=1

Copy link
Contributor

github-actions bot commented Mar 19, 2024

💻 Website Preview

The latest changes are available as preview in: https://67833bca.graphql-tools.pages.dev

@ardatan ardatan force-pushed the batch-delegation-key branch from b2f2866 to 78c9091 Compare April 19, 2024 16:00
@ardatan ardatan marked this pull request as ready for review April 19, 2024 16:01
@ardatan ardatan merged commit 9eee255 into master Apr 19, 2024
29 checks passed
@ardatan ardatan deleted the batch-delegation-key branch April 19, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supergraph handler fails with same field name
1 participant