-
-
Notifications
You must be signed in to change notification settings - Fork 834
Add oneOf to built-in directives #7695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 0baf2b0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📝 WalkthroughSummary by CodeRabbit
Summary by CodeRabbit
WalkthroughRegisters the Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Tests as Test Suite
participant ImportPkg as `@graphql-tools/import`
participant Fixtures as Schema Fixtures
Note over ImportPkg: builtinDirectives updated\n(includes `oneOf`)
Tests->>Fixtures: read fixtures (`c.graphql`, `d.graphql`)
Tests->>ImportPkg: importSchema(fixtures)
ImportPkg->>ImportPkg: include builtinDirectives (contains `oneOf`)
ImportPkg-->>Tests: produce SDL (input `D `@oneOf``, `C.id` -> `D!`)
Note over Tests,ImportPkg: verify expected SDL
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
a435f9b to
6ef935d
Compare
6ef935d to
0baf2b0
Compare
|
I'm not exactly sure why the Bun tests are failing. I haven't changed any code related to the failing test |
|
It is ok. It is our end! Thanks for the PR! |
As of september 2025
@oneOfis a built-in directive: https://spec.graphql.org/September2025/#sec--oneOfThis PR adds that to the definition list, so schemas using it will work without errors