Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect SIGTERM as termination event #1838

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Respect SIGTERM as termination event #1838

merged 1 commit into from
Nov 25, 2024

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented Nov 25, 2024

No description provided.

Copy link
Contributor

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@whatwg-node/server 0.9.60-alpha-20241125204954-df97787c12cbe5e1c71a2dfb774c3c9b9408eefb npm ↗︎ unpkg ↗︎

Copy link
Contributor

@benchmarks/node-fetch results (noConsumeBody)

   ✓ active_handles.................: avg=139.407978 min=77      med=140     max=201      p(90)=162     p(95)=167    
     data_received..................: 22 MB  725 kB/s
     data_sent......................: 14 MB  470 kB/s
     http_req_blocked...............: avg=3.68µs     min=611ns   med=1.47µs  max=6.77ms   p(90)=2.17µs  p(95)=2.58µs 
     http_req_connecting............: avg=1.7µs      min=0s      med=0s      max=5.43ms   p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=21ms       min=1.34ms  med=20.28ms max=712.31ms p(90)=26.83ms p(95)=30.4ms 
       { expected_response:true }...: avg=21ms       min=1.34ms  med=20.28ms max=712.31ms p(90)=26.83ms p(95)=30.4ms 
     http_req_failed................: 0.00%  ✓ 0           ✗ 142292
     http_req_receiving.............: avg=39.35µs    min=10.64µs med=26.4µs  max=25.24ms  p(90)=41.84µs p(95)=50.4µs 
     http_req_sending...............: avg=12.25µs    min=3.87µs  med=7.45µs  max=19.3ms   p(90)=10.91µs p(95)=15.41µs
     http_req_tls_handshaking.......: avg=0s         min=0s      med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=20.95ms    min=1.3ms   med=20.23ms max=712.21ms p(90)=26.78ms p(95)=30.28ms
     http_reqs......................: 142292 4740.851869/s
     iteration_duration.............: avg=42.13ms    min=5.36ms  med=40.57ms max=739.71ms p(90)=48.29ms p(95)=53.5ms 
     iterations.....................: 71124  2369.692944/s
     vus............................: 1      min=1         max=100 
     vus_max........................: 100    min=100       max=100 

Copy link
Contributor

@benchmarks/server results (undici)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 226434      ✗ 0     
     data_received..................: 23 MB   759 kB/s
     data_sent......................: 9.1 MB  302 kB/s
     http_req_blocked...............: avg=1.32µs   min=832ns    med=1.12µs   max=259.17µs p(90)=1.82µs   p(95)=1.98µs  
     http_req_connecting............: avg=0ns      min=0s       med=0s       max=111µs    p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=205.69µs min=149.76µs med=191.65µs max=38.69ms  p(90)=219.44µs p(95)=229.89µs
       { expected_response:true }...: avg=205.69µs min=149.76µs med=191.65µs max=38.69ms  p(90)=219.44µs p(95)=229.89µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 113217
     http_req_receiving.............: avg=25.01µs  min=13.84µs  med=23.54µs  max=989.23µs p(90)=30.42µs  p(95)=32.43µs 
     http_req_sending...............: avg=6.01µs   min=3.75µs   med=5.21µs   max=305.59µs p(90)=7.97µs   p(95)=8.41µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=174.66µs min=124.16µs med=160.74µs max=38.62ms  p(90)=184.56µs p(95)=193.85µs
     http_reqs......................: 113217  3773.748029/s
     iteration_duration.............: avg=260.74µs min=192.85µs med=246.11µs max=38.83ms  p(90)=277.42µs p(95)=290.62µs
     iterations.....................: 113217  3773.748029/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

Copy link
Contributor

@benchmarks/server results (native)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 231462      ✗ 0     
     data_received..................: 23 MB   775 kB/s
     data_sent......................: 9.3 MB  309 kB/s
     http_req_blocked...............: avg=1.42µs   min=911ns    med=1.23µs   max=201.65µs p(90)=1.91µs   p(95)=2.07µs  
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=152.92µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=196.88µs min=145.99µs med=184.6µs  max=9.65ms   p(90)=209.49µs p(95)=218.6µs 
       { expected_response:true }...: avg=196.88µs min=145.99µs med=184.6µs  max=9.65ms   p(90)=209.49µs p(95)=218.6µs 
     http_req_failed................: 0.00%   ✓ 0           ✗ 115731
     http_req_receiving.............: avg=25.99µs  min=14.12µs  med=24.67µs  max=454.92µs p(90)=31.74µs  p(95)=33.75µs 
     http_req_sending...............: avg=6.43µs   min=4.06µs   med=5.71µs   max=590.71µs p(90)=8.31µs   p(95)=9.04µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=164.45µs min=118.7µs  med=151.66µs max=9.59ms   p(90)=173.83µs p(95)=182.21µs
     http_reqs......................: 115731  3857.547121/s
     iteration_duration.............: avg=254.76µs min=199.09µs med=241.66µs max=9.75ms   p(90)=269.9µs  p(95)=281.08µs
     iterations.....................: 115731  3857.547121/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

Copy link
Contributor

@benchmarks/node-fetch results (consumeBody)

   ✓ active_handles.................: avg=139.506734 min=13      med=139     max=200     p(90)=161     p(95)=166    
     data_received..................: 22 MB  729 kB/s
     data_sent......................: 14 MB  468 kB/s
     http_req_blocked...............: avg=2.46µs     min=592ns   med=1.31µs  max=17.47ms p(90)=2.01µs  p(95)=2.3µs  
     http_req_connecting............: avg=651ns      min=0s      med=0s      max=2.95ms  p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=20.9ms     min=1.34ms  med=20.15ms max=1.04s   p(90)=26.19ms p(95)=28.9ms 
       { expected_response:true }...: avg=20.9ms     min=1.34ms  med=20.15ms max=1.04s   p(90)=26.19ms p(95)=28.9ms 
     http_req_failed................: 0.00%  ✓ 0           ✗ 143021
     http_req_receiving.............: avg=34.36µs    min=9.62µs  med=24.96µs max=19.56ms p(90)=39.04µs p(95)=45.69µs
     http_req_sending...............: avg=11.54µs    min=3.45µs  med=6.54µs  max=15.3ms  p(90)=9.96µs  p(95)=13.43µs
     http_req_tls_handshaking.......: avg=0s         min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=20.85ms    min=1.31ms  med=20.11ms max=1.04s   p(90)=26.14ms p(95)=28.8ms 
     http_reqs......................: 143021 4766.861512/s
     iteration_duration.............: avg=41.91ms    min=10.15ms med=40.23ms max=1.06s   p(90)=47.59ms p(95)=52.27ms
     iterations.....................: 71499  2383.047463/s
     vus............................: 95     min=95        max=100 
     vus_max........................: 100    min=100       max=100 

Copy link
Contributor

@benchmarks/server results (ponyfill)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 298284     ✗ 0     
     data_received..................: 29 MB   979 kB/s
     data_sent......................: 12 MB   398 kB/s
     http_req_blocked...............: avg=1.37µs   min=882ns    med=1.18µs   max=194.38µs p(90)=1.86µs   p(95)=2.03µs  
     http_req_connecting............: avg=0ns      min=0s       med=0s       max=136.28µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=139.97µs min=96.65µs  med=134.52µs max=8.08ms   p(90)=155.8µs  p(95)=161.99µs
       { expected_response:true }...: avg=139.97µs min=96.65µs  med=134.52µs max=8.08ms   p(90)=155.8µs  p(95)=161.99µs
     http_req_failed................: 0.00%   ✓ 0          ✗ 149142
     http_req_receiving.............: avg=24.29µs  min=12.59µs  med=23.13µs  max=3.04ms   p(90)=30.05µs  p(95)=32µs    
     http_req_sending...............: avg=6.22µs   min=4.1µs    med=5.46µs   max=3.56ms   p(90)=8.03µs   p(95)=8.52µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=109.45µs min=69.52µs  med=103.69µs max=7.87ms   p(90)=121.83µs p(95)=126.83µs
     http_reqs......................: 149142  4971.21862/s
     iteration_duration.............: avg=196.78µs min=140.58µs med=190.54µs max=8.47ms   p(90)=214.72µs p(95)=222.95µs
     iterations.....................: 149142  4971.21862/s
     vus............................: 1       min=1        max=1   
     vus_max........................: 1       min=1        max=1   

@ardatan ardatan marked this pull request as ready for review November 25, 2024 20:54
@ardatan ardatan merged commit 8947888 into master Nov 25, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant