Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming Release Changes #1927

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Upcoming Release Changes #1927

merged 1 commit into from
Dec 24, 2024

Conversation

theguild-bot
Copy link
Collaborator

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.

Releases

@whatwg-node/server@0.9.65

Patch Changes

  • #1926
    bae5de1
    Thanks @ardatan! - While calling handleNodeRequest or
    handleNodeRequestAndResponse, waitUntil is not added automatically as in requestListener for
    Node.js integration. This change adds waitUntil into the serverContext if not present.

    Fixes the issue with Fastify integration that uses the mentioned methods

@benchmarks/server@0.0.40

Patch Changes

  • Updated dependencies
    [bae5de1]:
    • @whatwg-node/server@0.9.65

@e2e/shared-server@0.0.126

Patch Changes

  • Updated dependencies
    [bae5de1]:
    • @whatwg-node/server@0.9.65

@e2e/vercel@0.0.126

Patch Changes

  • Updated dependencies []:
    • @e2e/shared-server@0.0.126

@theguild-bot theguild-bot force-pushed the changeset-release/master branch from ff31d6a to 8c7c37e Compare December 24, 2024 14:51
Copy link
Contributor

🚀 Snapshot Release (rc)

The latest changes of this PR are available as rc on npm (based on the declared changesets):

Package Version Info
@whatwg-node/server 0.9.65-rc-20241224145252-8c7c37ed217650fa2a40c07cbb0de045f8991249 npm ↗︎ unpkg ↗︎

Copy link
Contributor

@benchmarks/node-fetch results (consumeBody)

   ✓ active_handles.................: avg=140.424536 min=13      med=140     max=197     p(90)=161     p(95)=164    
     data_received..................: 22 MB  732 kB/s
     data_sent......................: 14 MB  470 kB/s
     http_req_blocked...............: avg=2.67µs     min=641ns   med=1.15µs  max=5.02ms  p(90)=1.99µs  p(95)=2.22µs 
     http_req_connecting............: avg=812ns      min=0s      med=0s      max=3.16ms  p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=20.82ms    min=2.78ms  med=20.14ms max=1.11s   p(90)=25.77ms p(95)=27.51ms
       { expected_response:true }...: avg=20.82ms    min=2.78ms  med=20.14ms max=1.11s   p(90)=25.77ms p(95)=27.51ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 143621
     http_req_receiving.............: avg=32.54µs    min=9.13µs  med=22.46µs max=12.8ms  p(90)=36.09µs p(95)=43.14µs
     http_req_sending...............: avg=11.04µs    min=3.22µs  med=5.56µs  max=13.96ms p(90)=9.26µs  p(95)=13.02µs
     http_req_tls_handshaking.......: avg=0s         min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=20.78ms    min=2.74ms  med=20.1ms  max=1.11s   p(90)=25.73ms p(95)=27.44ms
     http_reqs......................: 143621 4786.968717/s
     iteration_duration.............: avg=41.74ms    min=10.14ms med=40.12ms max=1.13s   p(90)=47.1ms  p(95)=51.5ms 
     iterations.....................: 71789  2392.767751/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100 

Copy link
Contributor

@benchmarks/server results (undici)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 214200      ✗ 0     
     data_received..................: 22 MB   718 kB/s
     data_sent......................: 8.6 MB  286 kB/s
     http_req_blocked...............: avg=1.43µs   min=871ns    med=1.21µs   max=173.51µs p(90)=1.92µs   p(95)=2.1µs   
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=120.98µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=215.41µs min=157.56µs med=201.91µs max=56.86ms  p(90)=231.5µs  p(95)=244.06µs
       { expected_response:true }...: avg=215.41µs min=157.56µs med=201.91µs max=56.86ms  p(90)=231.5µs  p(95)=244.06µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 107100
     http_req_receiving.............: avg=26.08µs  min=13.66µs  med=24.18µs  max=2.63ms   p(90)=31.65µs  p(95)=34.89µs 
     http_req_sending...............: avg=6.55µs   min=4.1µs    med=5.79µs   max=295.27µs p(90)=8.25µs   p(95)=9.35µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=182.77µs min=131.75µs med=169.75µs max=56.77ms  p(90)=195.48µs p(95)=206.8µs 
     http_reqs......................: 107100  3569.855356/s
     iteration_duration.............: avg=275.49µs min=201.89µs med=260.79µs max=57.02ms  p(90)=294.81µs p(95)=311.24µs
     iterations.....................: 107100  3569.855356/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

Copy link
Contributor

@benchmarks/node-fetch results (noConsumeBody)

   ✓ active_handles.................: avg=140.279209 min=12     med=141     max=189     p(90)=160     p(95)=165    
     data_received..................: 23 MB  760 kB/s
     data_sent......................: 15 MB  492 kB/s
     http_req_blocked...............: avg=2.23µs     min=621ns  med=1.4µs   max=3.72ms  p(90)=2.05µs  p(95)=2.34µs 
     http_req_connecting............: avg=378ns      min=0s     med=0s      max=2.96ms  p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=20.05ms    min=2.48ms med=19.45ms max=1.11s   p(90)=25.11ms p(95)=26.76ms
       { expected_response:true }...: avg=20.05ms    min=2.48ms med=19.45ms max=1.11s   p(90)=25.11ms p(95)=26.76ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 149044
     http_req_receiving.............: avg=32.44µs    min=8.8µs  med=22.7µs  max=13.77ms p(90)=37.51µs p(95)=44.49µs
     http_req_sending...............: avg=10.61µs    min=3.19µs med=6.49µs  max=13.89ms p(90)=9.75µs  p(95)=13.66µs
     http_req_tls_handshaking.......: avg=0s         min=0s     med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=20.01ms    min=2.23ms med=19.41ms max=1.11s   p(90)=25.07ms p(95)=26.7ms 
     http_reqs......................: 149044 4967.029393/s
     iteration_duration.............: avg=40.22ms    min=9.2ms  med=38.69ms max=1.13s   p(90)=44.16ms p(95)=49.38ms
     iterations.....................: 74507  2483.014808/s
     vus............................: 99     min=99        max=100 
     vus_max........................: 100    min=100       max=100 

Copy link
Contributor

@benchmarks/server results (native)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 203560      ✗ 0     
     data_received..................: 21 MB   682 kB/s
     data_sent......................: 8.1 MB  271 kB/s
     http_req_blocked...............: avg=1.48µs   min=892ns    med=1.24µs   max=321.04µs p(90)=2µs      p(95)=2.21µs  
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=122.78µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=230.59µs min=175.76µs med=218.63µs max=9.19ms   p(90)=247.66µs p(95)=260.77µs
       { expected_response:true }...: avg=230.59µs min=175.76µs med=218.63µs max=9.19ms   p(90)=247.66µs p(95)=260.77µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 101780
     http_req_receiving.............: avg=25.81µs  min=13.85µs  med=24.09µs  max=2.44ms   p(90)=31.36µs  p(95)=34.41µs 
     http_req_sending...............: avg=6.62µs   min=4.13µs   med=5.87µs   max=319.48µs p(90)=8.4µs    p(95)=9.42µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=198.14µs min=149.28µs med=186.37µs max=9.1ms    p(90)=212.21µs p(95)=223.89µs
     http_reqs......................: 101780  3392.537321/s
     iteration_duration.............: avg=290.17µs min=219.48µs med=277.37µs max=9.34ms   p(90)=310.1µs  p(95)=326.19µs
     iterations.....................: 101780  3392.537321/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

Copy link
Contributor

@benchmarks/server results (ponyfill)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 290422      ✗ 0     
     data_received..................: 29 MB   954 kB/s
     data_sent......................: 12 MB   387 kB/s
     http_req_blocked...............: avg=1.39µs   min=872ns    med=1.18µs   max=209.08µs p(90)=1.87µs   p(95)=2.05µs  
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=147.05µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=142.57µs min=96.95µs  med=137.61µs max=5.84ms   p(90)=160.12µs p(95)=168.03µs
       { expected_response:true }...: avg=142.57µs min=96.95µs  med=137.61µs max=5.84ms   p(90)=160.12µs p(95)=168.03µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 145211
     http_req_receiving.............: avg=24.98µs  min=12.23µs  med=23.44µs  max=2.41ms   p(90)=30.75µs  p(95)=33.7µs  
     http_req_sending...............: avg=6.42µs   min=4.05µs   med=5.61µs   max=326.64µs p(90)=8.14µs   p(95)=9.03µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=111.16µs min=68.93µs  med=105.77µs max=5.67ms   p(90)=125.29µs p(95)=131.74µs
     http_reqs......................: 145211  4840.146681/s
     iteration_duration.............: avg=201.96µs min=145.89µs med=196.28µs max=6.11ms   p(90)=222.29µs p(95)=232.81µs
     iterations.....................: 145211  4840.146681/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

@ardatan ardatan merged commit fdf8ac0 into master Dec 24, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants