feat: add scalars config option for custom GraphQL [scalar -> casual] mappings
#21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a minorr issue with stringification that tests didn't catch. Will update the PR. Update: Done |
ardeois
reviewed
Jul 13, 2020
tests/typescript-mock-data.spec.ts
Outdated
|
|
||
| const emailRegex = /(([^<>()[\]\\.,;:\s@\"]+(\.[^<>()[\]\\.,;:\s@\"]+)*)|(\".+\"))@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\])|(([a-zA-Z\-0-9]+\.)+[a-zA-Z]{2,}))/; | ||
| expect(result).toBeDefined(); | ||
| expect(emailRegex.test(result as string)).toBeTruthy(); |
There was a problem hiding this comment.
Our test suite force casual to return a predictable result, so I think you can check the result string directly instead of using a regex
There was a problem hiding this comment.
oh cool, didn't dig in too much and with a quick pass, I wasn't able to find something. I'll make sure to update
3nvi
commented
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Some apps use custom scalar for date-related stuff. This caused issues with the way
graphql-codegen-typescript-mock-datahandles autogenerated data, since a "random string" (the current default), may not always be what you need.This PR allows you to define mapping from your custom scalars to a casual embedded generator, allowing you to specify exactly how your scalar's autogenerated value will be populated
Closes #20
Caveats
To make configuration simple, a few "shortcuts" were taken. Namely:
casualkey (function or string) as a valid autogenerated value in order to align with the rest of the library