feat: add typesTransformUnderscore config option
#61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ardeois
reviewed
Oct 19, 2021
There was a problem hiding this comment.
Great thank you for your contribution !
I have few comments before I can merge. You hardcoded transformUnderscore to true in some places, which makes the output incorrect.
Check the snapshot, you will see your new unit test outputs invalid typescript
But otherwise, the logic is good!
|
@ardeois Thanks for the quick review 🙏 I've addressed your comments in the new commits. Let me know if you prefer me to squash them. |
ardeois
approved these changes
Oct 20, 2021
|
@VilhelmNielsen thanks for the changes, looks good now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #60